[Mesa-dev] [PATCH] virgl: Add command and flags to initiate debugging on the host

[Erik Faye-Lund]

On to., sep. 6, 2018 at 3:25 PM, Emil Velikov 
<emil.l.velikov at gmail.com> wrote:
> On 5 September 2018 at 16:34, Gert Wollny <gw.fossdev at gmail.com> 
> wrote:
> 
>>  +
>>  +enum virgl_debug_flags {
>>  +   debug_shader_tgsi = 1 << 0,
>>  +   debug_shader_glsl = 1 << 1,
>>  +   debug_shader_streamout = 1 << 2,
>>  +   debug_shader = debug_shader_tgsi | debug_shader_glsl | 
>> debug_shader_streamout,
>>  +   debug_cmd = 1 << 3,
>>  +   debug_object = 1 << 4,
>>  +   debug_blit = 1 << 5,
>>  +   debug_copy_resource = 1 << 6,
>>  +   /* debug_features = 1 << 7, can't be triggered from the guest, 
>> because
>>  +    * the code is run there before the guest can send commands */
>>  +   debug_all = (1 << 8) - 1,
>>  +};
>>  +
> Jfyi: These are effectively part of the ABI/protocol. A host/guest
> definitions mismatch will result in the wrong debug being printed.
> Ohh "the horror" I know, hence the jfyi ;-)

Good point. I think they should be moved to virgl_hw.h instead, as they 
need to be kept in sync.