[Mesa-dev] [PATCH v2 0/8] EGLDevice, take 2

[Mathias Fröhlich]

Hi Emil,

On Tuesday, 4 September 2018 20:32:57 CEST Emil Velikov wrote:
> Hi all,
> 
> Here is a re-spin of the EGLDevice series.
> 
> Changelog highlights:
>  - rebased on top of "egl/android: rework device probing"
>  - better patch split
>  - surfaceless cleanups are left to another series
>  - use better names for a handful of functions
>  - teardown nitpicks (completely leak-free, correct order)
>  - simplify SW device handling
>  - a number of DeviceSupports sanity checks
>  - enable the extensions when _fully_ supported
>  - directly use the render node, when no FD is given
> 
> Note: SW device support is still rough - I'd strongly recommend against
> trying to use it.
> 
> As always, review and feedback is greatly appreciated.

I think you want to compile and run with --enable-debug or the meson
build equivalent enabling asserts().
I did not look too close, today but applied to todays master I get some
asserts. One when compiling and at least two when running some test cases.

Anyhow thanks for updating so far!

best
Mathias

> 
> Thanks
> Emil
> 
> 
> Emil Velikov (8):
>   egl: add base EGL_EXT_device_base implementation
>   egl: add EGL_MESA_device_software support
>   egl: add EGL_EXT_device_drm support
>   egl: set the EGLDevice when creating a display
>   egl: enable EGL_EXT_device_{base,enumeration,query}
>   meson: egl: group dri2 bits separately from haiku
>   egl: add optional plat_opt to _eglFindDisplay()
>   egl: add EGL_platform_device support
> 
>  src/egl/Makefile.am                         |   3 +
>  src/egl/Makefile.sources                    |   2 +
>  src/egl/drivers/dri2/egl_dri2.c             |   3 +
>  src/egl/drivers/dri2/egl_dri2.h             |  14 +-
>  src/egl/drivers/dri2/platform_android.c     |   9 +
>  src/egl/drivers/dri2/platform_device.c      | 398 ++++++++++++++++++++
>  src/egl/drivers/dri2/platform_drm.c         |   9 +
>  src/egl/drivers/dri2/platform_surfaceless.c |  10 +-
>  src/egl/drivers/dri2/platform_wayland.c     |  18 +
>  src/egl/drivers/dri2/platform_x11.c         |  27 ++
>  src/egl/drivers/haiku/egl_haiku.cpp         |   8 +
>  src/egl/main/eglapi.c                       |  79 +++-
>  src/egl/main/egldevice.c                    | 319 ++++++++++++++++
>  src/egl/main/egldevice.h                    |  89 +++++
>  src/egl/main/egldisplay.c                   | 124 +++++-
>  src/egl/main/egldisplay.h                   |  14 +-
>  src/egl/main/eglentrypoint.h                |   4 +
>  src/egl/main/eglglobals.c                   |  13 +-
>  src/egl/main/eglglobals.h                   |   2 +
>  src/egl/main/egltypedefs.h                  |   2 +
>  src/egl/meson.build                         |  74 ++--
>  21 files changed, 1162 insertions(+), 59 deletions(-)
>  create mode 100644 src/egl/drivers/dri2/platform_device.c
>  create mode 100644 src/egl/main/egldevice.c
>  create mode 100644 src/egl/main/egldevice.h
> 
>