[Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

[Marek Olšák]

On Thu, Sep 6, 2018 at 6:25 AM, Michel Dänzer <michel at daenzer.net> wrote:
> On 2018-09-05 11:49 p.m., Marek Olšák wrote:
>> On Tue, Sep 4, 2018 at 2:35 PM, Marek Olšák <maraeo at gmail.com> wrote:
>>> On Mon, Sep 3, 2018 at 6:08 AM, Michel Dänzer <michel at daenzer.net> wrote:
>>>> On 2018-09-01 8:54 a.m., Marek Olšák wrote:
>>>>> From: Marek Olšák <marek.olsak at amd.com>
>>>>>
>>>>> +41% performance in debug builds
>>>>> (testing piglit/drawoverhead + u_threaded_context)
>>>>
>>>> Nice, but please include ministat output.
>>>
>>> I don't use ministat.
>>
>> What I meant is that ministat isn't useful with drawoverhead, because
>> drawoverhead repeats testing if results are volatile until it finds a
>> good average.
>
> Instead of that, it would be better to run the test multiple times, and
> let ministat take care of the statistical details.

Oh come on. The patch is too trivial to warrant so much testing.
Besides, the improvement is consistently around ~41%.

Marek