[Mesa-dev] [PATCH 1/4] gallium/u_inlines: normalize naming, use dst & src, style fixes

[Philipp Zabel]

Hi Marek,

there are two comments that will be confusing if they are not updated as
well:

On Sat, 2018-09-01 at 02:54 -0400, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> ---
>  src/gallium/auxiliary/util/u_inlines.h | 86 +++++++++++++-------------
>  1 file changed, 43 insertions(+), 43 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h
> index dee6f8f2d9e..7eb243779f7 100644
> --- a/src/gallium/auxiliary/util/u_inlines.h
> +++ b/src/gallium/auxiliary/util/u_inlines.h
> @@ -45,139 +45,139 @@
[...]
>  /**
>   * Update reference counting.
>   * The old thing pointed to, if any, will be unreferenced.
>   * Both 'ptr' and 'reference' may be NULL.

 * Both 'dst' and 'src' may be NULL.

>   * \return TRUE if the object's refcount hits zero and should be destroyed.
>   */
>  static inline boolean
> -pipe_reference_described(struct pipe_reference *ptr,
> -                         struct pipe_reference *reference,
> +pipe_reference_described(struct pipe_reference *dst,
> +                         struct pipe_reference *src,
>                           debug_reference_descriptor get_desc)
[...]  
>  /**
>   * Set *ptr to \p view with proper reference counting.

 * Set *dst to \p src with proper reference counting.

>   *
>   * The caller must guarantee that \p view and *ptr must have been created in

 * The caller must guarantee that \p src and *dst must have been created in

>   * the same context (if they exist), and that this must be the current context.
>   */
>  static inline void
> -pipe_sampler_view_reference(struct pipe_sampler_view **ptr,
> -                            struct pipe_sampler_view *view)
> +pipe_sampler_view_reference(struct pipe_sampler_view **dst,
> +                            struct pipe_sampler_view *src)

regards
Philipp