[Mesa-dev] [PATCH] meson: remove invalid "opencl" llvm component

[Dylan Baker]

Quoting Emil Velikov (2018-09-07 06:58:03)
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Seeming copy/paste mistake from configure.ac which uses $2 for the
> component and $3 for the fancy name printing.
> 
> Cc: Dylan Baker <dylan at pnwbakers.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 0d534b9b4a9..c8015489998 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1168,7 +1168,7 @@ if with_gallium_opencl
>      'all-targets', 'linker', 'coverage', 'instrumentation', 'ipo', 'irreader',
>      'lto', 'option', 'objcarcopts', 'profiledata',
>    ]
> -  llvm_optional_modules += ['coroutines', 'opencl']
> +  llvm_optional_modules += ['coroutines']
>  endif
>  
>  if with_amd_vk or with_gallium_radeonsi
> -- 
> 2.18.0
> 

Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

You could add a fixes tag to this, but it doesn't really matter since it's
optional and meson will just give you a "not found (optional)" message.

Thanks for spotting this.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180907/004687be/attachment-0001.sig>