[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106465

Andrés Gómez García <agomez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agomez at igalia.com,
                   |                            |currojerez at riseup.net

--- Comment #3 from Andrés Gómez García <agomez at igalia.com> ---
Curro, is this fixed by?

commit 5a6814780322988a7adee525899bca8a83907ab7
Author: Francisco Jerez <currojerez at riseup.net>
Date:   Fri Mar 16 13:43:27 2018 -0700

    Revert "mesa: simplify _mesa_is_image_unit_valid for buffers"

    This reverts commit c0ed52f6146c7e24e1275451773bd47c1eda3145.  It was
    preventing the image format validation from being done on buffer
    textures, which is required to ensure that the application doesn't
    attempt to bind a buffer texture with an internal format incompatible
    with the image unit format (e.g. of different texel size), which is
    not allowed by the spec (it's not allowed for *any* texture target,
    whether or not there is spec wording restricting this behavior
    specifically for buffer textures) and will cause the driver to
    calculate texel bounds incorrectly and potentially crash instead of
    the expected behavior.

    Cc: mesa-stable at lists.freedesktop.org
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106465
    Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180907/a79b6d29/attachment.html>