[Mesa-dev] Request for Mentor - XorgEvoc - Piglit for VA-API
Naveen Naidu
naveennaidu479 at gmail.com
Sun Sep 9 07:55:20 UTC 2018
Thank you for the information. Yes I have a AMD GPU, It is a Radeon r5
m430. But unfortunately it does not have a video decoder. But I also have
an integrated Intel HD 620 GPU, it's a kabylake and It had a video encoder
and video decoder. I have already discussed about this with Alex Deuscher
and he said that I will be fine with Intel HD 620 and I can carry on with
the project.
If you don't mind can you please let me know if i am on the right track?
Thank you very much for your time
P.S:- Sorry for the starting a new thread with the last mail. I am new to
mailing list. I will see to that I do not repeat the same mistake.
P . Naveen Naidu
On Sun, 9 Sep 2018 at 12:25, <mesa-dev-request at lists.freedesktop.org> wrote:
> Send mesa-dev mailing list submissions to
> mesa-dev at lists.freedesktop.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> or, via email, send a message with subject or body 'help' to
> mesa-dev-request at lists.freedesktop.org
>
> You can reach the person managing the list at
> mesa-dev-owner at lists.freedesktop.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of mesa-dev digest..."
>
>
> Today's Topics:
>
> 1. Re: [PATCH v2] gallium: Correctly handle no config context
> creation (Elie Tournier)
> 2. Re: [PATCH 2/2] gallium: try to fix the Windows build (Vinson Lee)
> 3. [Bug 107870] Undefined symbols for architecture x86_64:
> "_util_cpu_caps" (bugzilla-daemon at freedesktop.org)
> 4. [PATCH] utils/u_math: break dependency on gallium/utils
> (Dylan Baker)
> 5. Request for Mentor - XorgEvoc - Piglit for VA-API (Naveen Naidu)
> 6. Re: Request for Mentor - XorgEvoc - Piglit for VA-API
> (Benson Muite)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Sun, 9 Sep 2018 04:57:45 +0100
> From: Elie Tournier <tournier.elie at gmail.com>
> To: Marek Olšák <maraeo at gmail.com>
> Cc: ML mesa-dev <mesa-dev at lists.freedesktop.org>
> Subject: Re: [Mesa-dev] [PATCH v2] gallium: Correctly handle no config
> context creation
> Message-ID:
> <CA+SrN4ySwRPnD_ku1O-_KCF0wr+iL21RiydU=
> S5xVqxFArgo5w at mail.gmail.com>
> Content-Type: text/plain; charset="UTF-8"
>
> If you don't mind, can you please push this patch for me?
> I don't have git access.
>
> Thanks a lot,
> Elie
> On Fri, 7 Sep 2018 at 22:49, Marek Olšák <maraeo at gmail.com> wrote:
> >
> > Reviewed-by: Marek Olšák <marek.olsak at amd.com>
> >
> > Marek
> >
> > On Thu, Sep 6, 2018 at 5:46 AM, Elie Tournier <tournier.elie at gmail.com>
> wrote:
> > > This patch fixes the following Piglit test:
> > > spec at egl_mesa_configless_context@basic
> > > It also fixes few test in a virgl guest.
> > >
> > > v2: Evaluate the value of no_config (Ilia)
> > >
> > > Suggested-by: Emil Velikov <emil.velikov at collabora.com>
> > > Signed-off-by: Elie Tournier <elie.tournier at collabora.com>
> > > ---
> > > src/gallium/include/state_tracker/st_api.h | 2 ++
> > > src/gallium/state_trackers/dri/dri_screen.c | 4 +++-
> > > src/mesa/state_tracker/st_manager.c | 9 ++++++++-
> > > 3 files changed, 13 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/src/gallium/include/state_tracker/st_api.h
> b/src/gallium/include/state_tracker/st_api.h
> > > index 61152e3546..2b63b8a3d2 100644
> > > --- a/src/gallium/include/state_tracker/st_api.h
> > > +++ b/src/gallium/include/state_tracker/st_api.h
> > > @@ -190,6 +190,8 @@ struct st_egl_image
> > > */
> > > struct st_visual
> > > {
> > > + bool no_config;
> > > +
> > > /**
> > > * Available buffers. Bitfield of ST_ATTACHMENT_*_MASK bits.
> > > */
> > > diff --git a/src/gallium/state_trackers/dri/dri_screen.c
> b/src/gallium/state_trackers/dri/dri_screen.c
> > > index 027e85024f..308e23685e 100644
> > > --- a/src/gallium/state_trackers/dri/dri_screen.c
> > > +++ b/src/gallium/state_trackers/dri/dri_screen.c
> > > @@ -308,8 +308,10 @@ dri_fill_st_visual(struct st_visual *stvis,
> > > {
> > > memset(stvis, 0, sizeof(*stvis));
> > >
> > > - if (!mode)
> > > + if (!mode) {
> > > + stvis->no_config = true;
> > > return;
> > > + }
> > >
> > > /* Deduce the color format. */
> > > switch (mode->redMask) {
> > > diff --git a/src/mesa/state_tracker/st_manager.c
> b/src/mesa/state_tracker/st_manager.c
> > > index 69286b5791..9ed316b0f7 100644
> > > --- a/src/mesa/state_tracker/st_manager.c
> > > +++ b/src/mesa/state_tracker/st_manager.c
> > > @@ -834,6 +834,7 @@ st_api_create_context(struct st_api *stapi, struct
> st_manager *smapi,
> > > struct st_context *shared_ctx = (struct st_context *)
> shared_stctxi;
> > > struct st_context *st;
> > > struct pipe_context *pipe;
> > > + struct gl_config* mode_ptr;
> > > struct gl_config mode;
> > > gl_api api;
> > > bool no_error = false;
> > > @@ -893,7 +894,13 @@ st_api_create_context(struct st_api *stapi,
> struct st_manager *smapi,
> > > }
> > >
> > > st_visual_to_context_mode(&attribs->visual, &mode);
> > > - st = st_create_context(api, pipe, &mode, shared_ctx,
> > > +
> > > + if (attribs->visual.no_config)
> > > + mode_ptr = NULL;
> > > + else
> > > + mode_ptr = &mode;
> > > +
> > > + st = st_create_context(api, pipe, mode_ptr, shared_ctx,
> > > &attribs->options, no_error);
> > > if (!st) {
> > > *error = ST_CONTEXT_ERROR_NO_MEMORY;
> > > --
> > > 2.18.0
> > >
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
> ------------------------------
>
> Message: 2
> Date: Sat, 8 Sep 2018 22:22:27 -0700
> From: Vinson Lee <vlee at freedesktop.org>
> To: Marek Olšák <maraeo at gmail.com>
> Cc: ML mesa-dev <mesa-dev at lists.freedesktop.org>
> Subject: Re: [Mesa-dev] [PATCH 2/2] gallium: try to fix the Windows
> build
> Message-ID:
> <CACKvgLEBT5s+ycv2GixwHbfL3FnBQ=
> RCY6Uw4PKj9mAP-Nc84A at mail.gmail.com>
> Content-Type: text/plain; charset="UTF-8"
>
> On Sat, Sep 8, 2018 at 6:02 PM, Marek Olšák <maraeo at gmail.com> wrote:
> > From: Marek Olšák <marek.olsak at amd.com>
> >
> > Windows doesn't have thrd_current.
> > ---
> > src/gallium/auxiliary/util/u_helpers.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/src/gallium/auxiliary/util/u_helpers.c
> b/src/gallium/auxiliary/util/u_helpers.c
> > index f773360..8095242 100644
> > --- a/src/gallium/auxiliary/util/u_helpers.c
> > +++ b/src/gallium/auxiliary/util/u_helpers.c
> > @@ -127,20 +127,21 @@ util_upload_index_buffer(struct pipe_context *pipe,
> > * The function pins the current thread and driver threads to a group of
> > * CPU cores that share the same L3 cache. This is needed for good
> multi-
> > * threading performance on AMD Zen CPUs.
> > *
> > * \param upper_thread thread in the state tracker that also needs to
> be
> > * pinned.
> > */
> > void
> > util_context_thread_changed(struct pipe_context *ctx, thrd_t
> *upper_thread)
> > {
> > +#ifdef HAVE_PTHREAD
> > thrd_t current = thrd_current();
> > int cache = util_get_L3_for_pinned_thread(current,
> >
> util_cpu_caps.cores_per_L3);
> >
> > /* If the main thread is not pinned, choose the L3 cache. */
> > if (cache == -1) {
> > unsigned num_caches = util_cpu_caps.nr_cpus /
> > util_cpu_caps.cores_per_L3;
> > static unsigned last_cache;
> >
> > @@ -151,20 +152,21 @@ util_context_thread_changed(struct pipe_context
> *ctx, thrd_t *upper_thread)
> >
> > /* Tell the driver to pin its threads to the same L3 cache. */
> > if (ctx->set_context_param) {
> > ctx->set_context_param(ctx,
> PIPE_CONTEXT_PARAM_PIN_THREADS_TO_L3_CACHE,
> > cache);
> > }
> >
> > /* Do the same for the upper level thread if there is any (e.g.
> glthread) */
> > if (upper_thread)
> > util_pin_thread_to_L3(*upper_thread, cache,
> util_cpu_caps.cores_per_L3);
> > +#endif
> > }
> >
> > /* This is a helper for hardware bring-up. Don't remove. */
> > struct pipe_query *
> > util_begin_pipestat_query(struct pipe_context *ctx)
> > {
> > struct pipe_query *q =
> > ctx->create_query(ctx, PIPE_QUERY_PIPELINE_STATISTICS, 0);
> > if (!q)
> > return NULL;
> > --
> > 2.7.4
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
> Tested-by: Vinson Lee <vlee at freedesktop.org>
>
>
> ------------------------------
>
> Message: 3
> Date: Sun, 09 Sep 2018 05:34:28 +0000
> From: bugzilla-daemon at freedesktop.org
> To: mesa-dev at lists.freedesktop.org
> Subject: [Mesa-dev] [Bug 107870] Undefined symbols for architecture
> x86_64: "_util_cpu_caps"
> Message-ID: <bug-107870-598 at http.bugs.freedesktop.org/>
> Content-Type: text/plain; charset="utf-8"
>
> https://bugs.freedesktop.org/show_bug.cgi?id=107870
>
> Bug ID: 107870
> Summary: Undefined symbols for architecture x86_64:
> "_util_cpu_caps"
> Product: Mesa
> Version: git
> Hardware: x86-64 (AMD64)
> OS: Mac OS X (All)
> Status: NEW
> Keywords: regression
> Severity: normal
> Priority: medium
> Component: Mesa core
> Assignee: mesa-dev at lists.freedesktop.org
> Reporter: vlee at freedesktop.org
> QA Contact: mesa-dev at lists.freedesktop.org
> CC: baker.dylan.c at gmail.com
>
> CXXLD mesa_dri_drivers.la
> Undefined symbols for architecture x86_64:
> "_util_cpu_caps", referenced from:
> _util_fpstate_get in libmesa.a(libmesautil_la-u_math.o)
> _util_fpstate_set_denorms_to_zero in
> libmesa.a(libmesautil_la-u_math.o)
> _util_fpstate_set in libmesa.a(libmesautil_la-u_math.o)
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
> You are the QA Contact for the bug.
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> https://lists.freedesktop.org/archives/mesa-dev/attachments/20180909/d81eb216/attachment-0001.html
> >
>
> ------------------------------
>
> Message: 4
> Date: Sat, 8 Sep 2018 23:39:44 -0700
> From: Dylan Baker <dylan at pnwbakers.com>
> To: mesa-dev at lists.freedesktop.org
> Subject: [Mesa-dev] [PATCH] utils/u_math: break dependency on
> gallium/utils
> Message-ID: <20180909063944.3230-1-dylan at pnwbakers.com>
>
> Currently u_math needs gallium utils for cpu detection. Most of what
> u_math uses out of u_cpu_detection is duplicated in src/mesa/x86
> (surprise!), so I've just reworked it as much as possible to use the
> x86/common_x86_features macros instead of the gallium ones. There is
> one small function that was copied over, as promoting u_cpu_detection is
> itself a fairly hefty undertaking, as it depends on u_debug, and this
> fixes the bug for now.
>
> bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107870
> cc: vlee at freedesktop.org
> ---
>
> I have no idea if this fixes the build on mac, I had this in a branch
> where I
> started replacing more of imports.{h,c} with utils stuff, and this fixes
> some
> build problems on Linux. I don't have a mac to test on and I wont until
> Monday.
> If this works let me know.
>
> src/util/u_math.c | 43 ++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 38 insertions(+), 5 deletions(-)
>
> diff --git a/src/util/u_math.c b/src/util/u_math.c
> index c58af911be7..bf0c398eeec 100644
> --- a/src/util/u_math.c
> +++ b/src/util/u_math.c
> @@ -29,7 +29,7 @@
>
> #include "pipe/p_config.h"
> #include "util/u_math.h"
> -#include "util/u_cpu_detect.h"
> +#include "x86/common_x86_features.h"
>
> #if defined(PIPE_ARCH_SSE)
> #include <xmmintrin.h>
> @@ -90,7 +90,7 @@ util_fpstate_get(void)
> unsigned mxcsr = 0;
>
> #if defined(PIPE_ARCH_SSE)
> - if (util_cpu_caps.has_sse) {
> + if (cpu_has_xmm) {
> mxcsr = _mm_getcsr();
> }
> #endif
> @@ -98,6 +98,31 @@ util_fpstate_get(void)
> return mxcsr;
> }
>
> +/* TODO: this was copied from u_cpu_detection. It's another case of
> duplication
> + * between gallium and core mesa, and it would be nice to get rid of that
> + * duplication as well.
> + */
> +#if defined(PIPE_ARCH_X86)
> +PIPE_ALIGN_STACK static inline bool sse2_has_daz(void)
> +{
> + struct {
> + uint32_t pad1[7];
> + uint32_t mxcsr_mask;
> + uint32_t pad2[128-8];
> + } PIPE_ALIGN_VAR(16) fxarea;
> +
> + fxarea.mxcsr_mask = 0;
> +#if defined(PIPE_CC_GCC)
> + __asm __volatile ("fxsave %0" : "+m" (fxarea));
> +#elif defined(PIPE_CC_MSVC) || defined(PIPE_CC_ICL)
> + _fxsave(&fxarea);
> +#else
> + fxarea.mxcsr_mask = 0;
> +#endif
> + return !!(fxarea.mxcsr_mask & (1 << 6));
> +}
> +#endif
> +
> /**
> * Make sure that the fp treats the denormalized floating
> * point numbers as zero.
> @@ -108,13 +133,21 @@ unsigned
> util_fpstate_set_denorms_to_zero(unsigned current_mxcsr)
> {
> #if defined(PIPE_ARCH_SSE)
> - if (util_cpu_caps.has_sse) {
> + if (cpu_has_xmm) {
> /* Enable flush to zero mode */
> current_mxcsr |= _MM_FLUSH_ZERO_MASK;
> - if (util_cpu_caps.has_daz) {
> + /* x86_64 cpus always have daz, as do cpus with sse3 in fact,
> there's
> + * basically only a handful of very early pentium 4's that have
> sse2 but
> + * not daz.
> + */
> +# if !defined(PIPE_ARCH_x86_64) && !defined(PIPE_ARCH_SSSE3)
> + if (sse2_has_daz()) {
> +# endif
> /* Enable denormals are zero mode */
> current_mxcsr |= _MM_DENORMALS_ZERO_MASK;
> +# if !defined(PIPE_ARCH_x86_64) && !defined(PIPE_ARCH_SSSE3)
> }
> +#endif
> util_fpstate_set(current_mxcsr);
> }
> #endif
> @@ -130,7 +163,7 @@ void
> util_fpstate_set(unsigned mxcsr)
> {
> #if defined(PIPE_ARCH_SSE)
> - if (util_cpu_caps.has_sse) {
> + if (cpu_has_xmm) {
> _mm_setcsr(mxcsr);
> }
> #endif
> --
> 2.18.0
>
>
>
> ------------------------------
>
> Message: 5
> Date: Sun, 9 Sep 2018 12:11:45 +0530
> From: Naveen Naidu <naveennaidu479 at gmail.com>
> To: mesa-dev at lists.freedesktop.org
> Subject: [Mesa-dev] Request for Mentor - XorgEvoc - Piglit for VA-API
> Message-ID:
> <CAB=7UR0+2ENn5y7u3pov=yt9aduG-hG3-WG_CboL_=o=
> J0kxsw at mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
>
> Hello Everyone,
>
> I am Naveen a Junior year computer science undergrad from India. I really
> apologize for disturbing you all again. But I have been going through the
> available projects for the XorgEVoC program and the project *Piglit for
> VA-API *caught my attention. I have mailed last week looking out for
> mentors for the project, but unfortunately this email did not receive
> attention due to the busy schedule at Xorg I guess.
>
> I have been working on the project since the last time I mailed asking for
> directions. As Alex mentioned in his reply, I have read through the piglit
> documentation and am now sufficiently familiar with piglit.
>
> Things that I have done until now:-
>
> 1. Read through the Piglit documentation (Capable of understanding and
> writing small tests using piglit)
> 2. Compiled gstreamer, and also set up the gst-uninstalled environment.
> 3. Understood about the architecture of gstreamer.
> 4. Currently reading about VA-API.
> 5. Planning to implement a simple VA-API app to better understand the
> type of tests I need to write for VA-API
>
>
> I am comfortable with both C and Python and given the skill set I am
> confident of accomplishing the project. I would thus like to discuss the
> details and deliverable of the project with my potential mentor and would
> like to know how I can proceed with the project.
>
> Since no potential mentor was mentioned in the Idea's Page, it would be
> really kind of someone if they are willing to be a mentor for the project.
> I can assure you that I will put the best of my efforts and dedication into
> the project and will see that the project is completed.
>
> Thank you for your valuable time.
>
> Regards,
> Naveen Naidu
> https://github.com/Naveenaidu
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> https://lists.freedesktop.org/archives/mesa-dev/attachments/20180909/b5f18641/attachment-0001.html
> >
>
> ------------------------------
>
> Message: 6
> Date: Sun, 9 Sep 2018 09:54:06 +0300
> From: Benson Muite <benson.muite at ut.ee>
> To: mesa-dev at lists.freedesktop.org
> Subject: Re: [Mesa-dev] Request for Mentor - XorgEvoc - Piglit for
> VA-API
> Message-ID: <44cad40b-a1c3-cc91-625e-856644a65181 at ut.ee>
> Content-Type: text/plain; charset="utf-8"; Format="flowed"
>
> Welcome! From the page:
>
> https://www.x.org/wiki/SummerOfCodeIdeas/
>
> Might try and ping Christian König. Do you have an AMD GPU?
>
> Benson
>
> On 09/09/2018 09:41 AM, Naveen Naidu wrote:
> > Hello Everyone,
> >
> > I am Naveen a Junior year computer science undergrad from India. I
> > really apologize for disturbing you all again. But I have been going
> > through the available projects for the XorgEVoC program and the
> > project *Piglit for VA-API *caught my attention. I have mailed last
> > week looking out for mentors for the project, but unfortunately this
> > email did not receive attention due to the busy schedule at Xorg I guess.
> >
> > I have been working on the project since the last time I mailed asking
> > for directions. As Alex mentioned in his reply, I have read through
> > the piglit documentation and am now sufficiently familiar with piglit.
> >
> > Things that I have done until now:-
> >
> > 1. Read through the Piglit documentation (Capable of understanding
> > and writing small tests using piglit)
> > 2. Compiled gstreamer, and also set up the gst-uninstalled environment.
> > 3. Understood about the architecture of gstreamer.
> > 4. Currently reading about VA-API.
> > 5. Planning to implement a simple VA-API app to better understand the
> > type of tests I need to write for VA-API
> >
> >
> > I am comfortable with both C and Python and given the skill set I am
> > confident of accomplishing the project. I would thus like to discuss
> > the details and deliverable of the project with my potential mentor
> > and would like to know how I can proceed with the project.
> >
> > Since no potential mentor was mentioned in the Idea's Page, it would
> > be really kind of someone if they are willing to be a mentor for the
> > project. I can assure you that I will put the best of my efforts and
> > dedication into the project and will see that the project is completed.
> >
> > Thank you for your valuable time.
> >
> > Regards,
> > Naveen Naidu
> > https://github.com/Naveenaidu
> >
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> https://lists.freedesktop.org/archives/mesa-dev/attachments/20180909/9585c507/attachment.html
> >
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
> ------------------------------
>
> End of mesa-dev Digest, Vol 102, Issue 134
> ******************************************
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180909/c7f28519/attachment-0001.html>
More information about the mesa-dev
mailing list