[Mesa-dev] [PATCH 2/4] gallium/auxiliary: don't dereference counters twice needlessly

Michel Dänzer michel at daenzer.net
Tue Sep 11 08:11:22 UTC 2018


On 2018-09-10 8:55 p.m., Marek Olšák wrote:
> On Mon, Sep 10, 2018 at 11:41 AM, Michel Dänzer <michel at daenzer.net> wrote:
>> On 2018-09-07 11:35 p.m., Marek Olšák wrote:
>>> From: Marek Olšák <marek.olsak at amd.com>
>>>
>>> +1.2% performance with:
>>>     piglit/drawoverhead - DrawElements (no state changes) on radeonsi
>>
>> No meaningless number (which is most likely the same order of magnitude,
>> maybe even smaller than the deviation between test runs) in the commit
>> log please.
> 
> I think you are bikeshedding a little too much. The improvement was
> reproducible with many runs.

I don't doubt that, but a single number just can't adequately describe a
performance delta. Surely you can understand that.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the mesa-dev mailing list