[Mesa-dev] [PATCH 3/4] anv/memcpy: Use addresses instead of bo+offset
Eric Engestrom
eric.engestrom at intel.com
Wed Sep 12 16:10:21 UTC 2018
On Wednesday, 2018-09-12 00:06:50 -0500, Jason Ekstrand wrote:
This and 4/4 are
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
> src/intel/vulkan/anv_genX.h | 6 ++---
> src/intel/vulkan/genX_cmd_buffer.c | 28 +++++++++++++++---------
> src/intel/vulkan/genX_gpu_memcpy.c | 35 ++++++++++++------------------
> 3 files changed, 34 insertions(+), 35 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_genX.h b/src/intel/vulkan/anv_genX.h
> index 9b5665845ef..bef9b5bde4e 100644
> --- a/src/intel/vulkan/anv_genX.h
> +++ b/src/intel/vulkan/anv_genX.h
> @@ -73,13 +73,11 @@ genX(emit_urb_setup)(struct anv_device *device, struct anv_batch *batch,
> const unsigned entry_size[4]);
>
> void genX(cmd_buffer_so_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> - struct anv_bo *dst, uint32_t dst_offset,
> - struct anv_bo *src, uint32_t src_offset,
> + struct anv_address dst, struct anv_address src,
> uint32_t size);
>
> void genX(cmd_buffer_mi_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> - struct anv_bo *dst, uint32_t dst_offset,
> - struct anv_bo *src, uint32_t src_offset,
> + struct anv_address dst, struct anv_address src,
> uint32_t size);
>
> void genX(blorp_exec)(struct blorp_batch *batch,
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c
> index 80bebf5a12c..933566e91e7 100644
> --- a/src/intel/vulkan/genX_cmd_buffer.c
> +++ b/src/intel/vulkan/genX_cmd_buffer.c
> @@ -872,20 +872,21 @@ genX(copy_fast_clear_dwords)(struct anv_cmd_buffer *cmd_buffer,
> assert(cmd_buffer && image);
> assert(image->aspects & VK_IMAGE_ASPECT_ANY_COLOR_BIT_ANV);
>
> - struct anv_bo *ss_bo =
> - &cmd_buffer->device->surface_state_pool.block_pool.bo;
> - uint32_t ss_clear_offset = surface_state.offset +
> - cmd_buffer->device->isl_dev.ss.clear_value_offset;
> + struct anv_address ss_clear_addr = {
> + .bo = &cmd_buffer->device->surface_state_pool.block_pool.bo,
> + .offset = surface_state.offset +
> + cmd_buffer->device->isl_dev.ss.clear_value_offset,
> + };
> const struct anv_address entry_addr =
> anv_image_get_clear_color_addr(cmd_buffer->device, image, aspect);
> unsigned copy_size = cmd_buffer->device->isl_dev.ss.clear_value_size;
>
> if (copy_from_surface_state) {
> - genX(cmd_buffer_mi_memcpy)(cmd_buffer, entry_addr.bo, entry_addr.offset,
> - ss_bo, ss_clear_offset, copy_size);
> + genX(cmd_buffer_mi_memcpy)(cmd_buffer, entry_addr,
> + ss_clear_addr, copy_size);
> } else {
> - genX(cmd_buffer_mi_memcpy)(cmd_buffer, ss_bo, ss_clear_offset,
> - entry_addr.bo, entry_addr.offset, copy_size);
> + genX(cmd_buffer_mi_memcpy)(cmd_buffer, ss_clear_addr,
> + entry_addr, copy_size);
>
> /* Updating a surface state object may require that the state cache be
> * invalidated. From the SKL PRM, Shared Functions -> State -> State
> @@ -1501,8 +1502,15 @@ genX(CmdExecuteCommands)(
> struct anv_state dst_state = secondary->state.render_pass_states;
> assert(src_state.alloc_size == dst_state.alloc_size);
>
> - genX(cmd_buffer_so_memcpy)(primary, ss_bo, dst_state.offset,
> - ss_bo, src_state.offset,
> + genX(cmd_buffer_so_memcpy)(primary,
> + (struct anv_address) {
> + .bo = ss_bo,
> + .offset = dst_state.offset,
> + },
> + (struct anv_address) {
> + .bo = ss_bo,
> + .offset = src_state.offset,
> + },
> src_state.alloc_size);
> }
>
> diff --git a/src/intel/vulkan/genX_gpu_memcpy.c b/src/intel/vulkan/genX_gpu_memcpy.c
> index cba820a1866..2b39f2fc009 100644
> --- a/src/intel/vulkan/genX_gpu_memcpy.c
> +++ b/src/intel/vulkan/genX_gpu_memcpy.c
> @@ -53,14 +53,13 @@ gcd_pow2_u64(uint64_t a, uint64_t b)
>
> void
> genX(cmd_buffer_mi_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> - struct anv_bo *dst, uint32_t dst_offset,
> - struct anv_bo *src, uint32_t src_offset,
> + struct anv_address dst, struct anv_address src,
> uint32_t size)
> {
> /* This memcpy operates in units of dwords. */
> assert(size % 4 == 0);
> - assert(dst_offset % 4 == 0);
> - assert(src_offset % 4 == 0);
> + assert(dst.offset % 4 == 0);
> + assert(src.offset % 4 == 0);
>
> #if GEN_GEN == 7
> /* On gen7, the combination of commands used here(MI_LOAD_REGISTER_MEM
> @@ -85,14 +84,10 @@ genX(cmd_buffer_mi_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> #endif
>
> for (uint32_t i = 0; i < size; i += 4) {
> - const struct anv_address src_addr =
> - (struct anv_address) { src, src_offset + i};
> - const struct anv_address dst_addr =
> - (struct anv_address) { dst, dst_offset + i};
> #if GEN_GEN >= 8
> anv_batch_emit(&cmd_buffer->batch, GENX(MI_COPY_MEM_MEM), cp) {
> - cp.DestinationMemoryAddress = dst_addr;
> - cp.SourceMemoryAddress = src_addr;
> + cp.DestinationMemoryAddress = anv_address_add(dst, i);
> + cp.SourceMemoryAddress = anv_address_add(src, i);
> }
> #else
> /* IVB does not have a general purpose register for command streamer
> @@ -101,11 +96,11 @@ genX(cmd_buffer_mi_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> #define TEMP_REG 0x2440 /* GEN7_3DPRIM_BASE_VERTEX */
> anv_batch_emit(&cmd_buffer->batch, GENX(MI_LOAD_REGISTER_MEM), load) {
> load.RegisterAddress = TEMP_REG;
> - load.MemoryAddress = src_addr;
> + load.MemoryAddress = anv_address_add(src, i);
> }
> anv_batch_emit(&cmd_buffer->batch, GENX(MI_STORE_REGISTER_MEM), store) {
> store.RegisterAddress = TEMP_REG;
> - store.MemoryAddress = dst_addr;
> + store.MemoryAddress = anv_address_add(dst, i);
> }
> #undef TEMP_REG
> #endif
> @@ -115,15 +110,14 @@ genX(cmd_buffer_mi_memcpy)(struct anv_cmd_buffer *cmd_buffer,
>
> void
> genX(cmd_buffer_so_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> - struct anv_bo *dst, uint32_t dst_offset,
> - struct anv_bo *src, uint32_t src_offset,
> + struct anv_address dst, struct anv_address src,
> uint32_t size)
> {
> if (size == 0)
> return;
>
> - assert(dst_offset + size <= dst->size);
> - assert(src_offset + size <= src->size);
> + assert(dst.offset + size <= dst.bo->size);
> + assert(src.offset + size <= src.bo->size);
>
> /* The maximum copy block size is 4 32-bit components at a time. */
> assert(size % 4 == 0);
> @@ -154,14 +148,14 @@ genX(cmd_buffer_so_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> &(struct GENX(VERTEX_BUFFER_STATE)) {
> .VertexBufferIndex = 32, /* Reserved for this */
> .AddressModifyEnable = true,
> - .BufferStartingAddress = { src, src_offset },
> + .BufferStartingAddress = src,
> .BufferPitch = bs,
> #if (GEN_GEN >= 8)
> .MemoryObjectControlState = GENX(MOCS),
> .BufferSize = size,
> #else
> .VertexBufferMemoryObjectControlState = GENX(MOCS),
> - .EndAddress = { src, src_offset + size - 1 },
> + .EndAddress = anv_address_add(src, size - 1),
> #endif
> });
>
> @@ -218,15 +212,14 @@ genX(cmd_buffer_so_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> anv_batch_emit(&cmd_buffer->batch, GENX(3DSTATE_SO_BUFFER), sob) {
> sob.SOBufferIndex = 0;
> sob.SOBufferObjectControlState = GENX(MOCS);
> - sob.SurfaceBaseAddress = (struct anv_address) { dst, dst_offset };
> + sob.SurfaceBaseAddress = dst;
>
> #if GEN_GEN >= 8
> sob.SOBufferEnable = true;
> sob.SurfaceSize = size / 4 - 1;
> #else
> sob.SurfacePitch = bs;
> - sob.SurfaceEndAddress = sob.SurfaceBaseAddress;
> - sob.SurfaceEndAddress.offset += size;
> + sob.SurfaceEndAddress = anv_address_add(dst, size);
> #endif
>
> #if GEN_GEN >= 8
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
More information about the mesa-dev
mailing list