[Mesa-dev] [PATCH v1] glsl: missed error_emitted for do_assignment
Sergii Romantsov
sergii.romantsov at gmail.com
Fri Sep 14 13:39:54 UTC 2018
During do_assignment a validation of rhs may fail.
Because of lack error_emitted an error_value may not be generated.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107547
Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
---
src/compiler/glsl/ast_to_hir.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index 5d3f10b..da1654b 100644
--- a/src/compiler/glsl/ast_to_hir.cpp
+++ b/src/compiler/glsl/ast_to_hir.cpp
@@ -1013,6 +1013,8 @@ do_assignment(exec_list *instructions, struct _mesa_glsl_parse_state *state,
mark_whole_array_access(lhs);
}
}
+ else
+ error_emitted = true;
/* Most callers of do_assignment (assign, add_assign, pre_inc/dec,
* but not post_inc) need the converted assigned value as an rvalue
--
2.7.4
More information about the mesa-dev
mailing list