[Mesa-dev] [PATCH 2/4] anv/so_memcpy: Use the correct SO_BUFFER size on gen8+

Nanley Chery nanleychery at gmail.com
Fri Sep 14 19:57:37 UTC 2018


On Wed, Sep 12, 2018 at 12:06:49AM -0500, Jason Ekstrand wrote:
> This shouldn't matter as we'll never write OOB anyway but we may as well
> get it right.  It's supposed to be in dwords - 1.
> ---
>  src/intel/vulkan/genX_gpu_memcpy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

This patch is
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>

> diff --git a/src/intel/vulkan/genX_gpu_memcpy.c b/src/intel/vulkan/genX_gpu_memcpy.c
> index 57abd8cd5c1..cba820a1866 100644
> --- a/src/intel/vulkan/genX_gpu_memcpy.c
> +++ b/src/intel/vulkan/genX_gpu_memcpy.c
> @@ -222,7 +222,7 @@ genX(cmd_buffer_so_memcpy)(struct anv_cmd_buffer *cmd_buffer,
>  
>  #if GEN_GEN >= 8
>        sob.SOBufferEnable = true;
> -      sob.SurfaceSize = size - 1;
> +      sob.SurfaceSize = size / 4 - 1;
>  #else
>        sob.SurfacePitch = bs;
>        sob.SurfaceEndAddress = sob.SurfaceBaseAddress;
> -- 
> 2.17.1
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list