[Mesa-dev] [PATCH 2/2] mesa: FramebufferParameteri parameter checking

Eric Engestrom eric.engestrom at intel.com
Sat Sep 15 06:02:35 UTC 2018


On Friday, 2018-09-14 12:09:39 -0700, Fritz Koenig wrote:
> Missing break; causes parameter checking to
> never pass GL_FRAMEBUFFER_FLIP_Y_MESA paramers.
> 
> Fixes: 318c265160 ("mesa: GL_MESA_framebuffer_flip_y extension [v4]")

Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

> ---
>  src/mesa/main/fbobject.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index edb86438e3..3263fce845 100644
> --- a/src/mesa/main/fbobject.c
> +++ b/src/mesa/main/fbobject.c
> @@ -1503,6 +1503,7 @@ framebuffer_parameteri(struct gl_context *ctx, struct gl_framebuffer *fb,
>        if (!ctx->Extensions.MESA_framebuffer_flip_y)
>           goto invalid_pname_enum;
>        cannot_be_winsys_fbo = true;
> +      break;
>     default:
>        goto invalid_pname_enum;
>     }
> -- 
> 2.19.0.397.gdd90340f6a-goog
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list