[Mesa-dev] [PATCH] radv: Optimize rebinding the same descriptor set.

[Samuel Pitoiset]

On 9/16/18 2:21 AM, Bas Nieuwenhuizen wrote:
> Thsi makes it cheaper to just change the dynamic offsets with

typo: This

Sounds reasonable.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

> the same descriptor sets.
> 
> Suggested-by: Philip Rebohle <philip.rebohle at tu-dortmund.de>
> ---
>   src/amd/vulkan/radv_cmd_buffer.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index d492456d6b8..2f168321197 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -2464,7 +2464,13 @@ void radv_CmdBindDescriptorSets(
>   	for (unsigned i = 0; i < descriptorSetCount; ++i) {
>   		unsigned idx = i + firstSet;
>   		RADV_FROM_HANDLE(radv_descriptor_set, set, pDescriptorSets[i]);
> -		radv_bind_descriptor_set(cmd_buffer, pipelineBindPoint, set, idx);
> +
> +		/* If the set is already bound we only need to update the
> +		 * (potentially changed) dynamic offsets. */
> +		if (descriptors_state->sets[idx] != set ||
> +		    !(descriptors_state->valid & (1u << idx))) {
> +			radv_bind_descriptor_set(cmd_buffer, pipelineBindPoint, set, idx);
> +		}
>   
>   		for(unsigned j = 0; j < set->layout->dynamic_offset_count; ++j, ++dyn_idx) {
>   			unsigned idx = j + layout->set[i + firstSet].dynamic_offset_start;
>