[Mesa-dev] [PATCH v1] autotools: multiple definitions for libmesagallium

[Dylan Baker]

I'm not crazy about this solution, it seems more like papering over a bug than
fixing the bug. I'm really curious why we can reproduce this in autotools but
not meson as well.

Dylan

Quoting Sergii Romantsov (2018-09-17 03:23:04)
> Error of multiple definitions for libmesagallium and libmesautil may be
> fixed by linker-option allow-multiple-definition
> 
> CC: Dylan Baker <dylan at pnwbakers.com>
> Fixes: 8396043f304b (Replace uses of _mesa_bitcount with util_bitcount)
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107923
> Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
> ---
>  src/gallium/targets/libgl-xlib/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/gallium/targets/libgl-xlib/Makefile.am b/src/gallium/targets/libgl-xlib/Makefile.am
> index dc7c6ed..094d4be 100644
> --- a/src/gallium/targets/libgl-xlib/Makefile.am
> +++ b/src/gallium/targets/libgl-xlib/Makefile.am
> @@ -46,6 +46,7 @@ lib at GL_LIB@_la_SOURCES = xlib.c
>  lib at GL_LIB@_la_LDFLAGS = \
>         -no-undefined \
>         -version-number 1:5:0 \
> +       -Wl,--allow-multiple-definition \
>         $(BSYMBOLIC) \
>         $(GC_SECTIONS) \
>         $(LD_NO_UNDEFINED)
> -- 
> 2.7.4
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180917/80292414/attachment.sig>