[Mesa-dev] [PATCH] i965: remove outdated comment about TCS passthrough

Caio Marcelo de Oliveira Filho caio.oliveira at intel.com
Tue Sep 18 01:37:42 UTC 2018


Since commit 75881bed9e1 "i965: Rework the TCS passthrough shader to
use NIR." the created nir_shader is not dummy, and it is compiled by
the backend like the others.
---
 src/mesa/drivers/dri/i965/brw_tcs.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_tcs.c b/src/mesa/drivers/dri/i965/brw_tcs.c
index 53611144ff5..823933ef77f 100644
--- a/src/mesa/drivers/dri/i965/brw_tcs.c
+++ b/src/mesa/drivers/dri/i965/brw_tcs.c
@@ -167,10 +167,6 @@ brw_codegen_tcs_prog(struct brw_context *brw, struct brw_program *tcp,
    if (tcp) {
       nir = tcp->program.nir;
    } else {
-      /* Create a dummy nir_shader.  We won't actually use NIR code to
-       * generate assembly (it's easier to generate assembly directly),
-       * but the whole compiler assumes one of these exists.
-       */
       const nir_shader_compiler_options *options =
          ctx->Const.ShaderCompilerOptions[MESA_SHADER_TESS_CTRL].NirOptions;
       nir = create_passthrough_tcs(mem_ctx, compiler, options, key);
-- 
2.19.0



More information about the mesa-dev mailing list