[Mesa-dev] [PATCH 1/3] mesa: use GLsizeiptrARB, GLintptrARB in bufferobj.c

Mathias Fröhlich Mathias.Froehlich at gmx.net
Tue Sep 18 04:32:31 UTC 2018

Good Morning,

On Tuesday, 18 September 2018 05:10:04 CEST Brian Paul wrote:
> The function pointer declarations in dd.h for the BufferData() and
> BufferSubData() use the ARB-suffixed datatypes.  This patch changes
> the buffer_data_fallback() and buffer_sub_data_fallback() functions
> to use those datatypes too.
> This fixes a build warning when building 32-bit libraries.  Evidently,
> GLsizeiptrARB and GLsizeiptr are defined differently in that situation.
> All all implementations of these driver hooks use the ARB-suffixed
> types.

Hmm, all of GL{int,sizei}ptr{,ARB} are typedefs to ptrdiff_t by gl.xml.
That makes me think that you may be running into some other problem
for your build that you may want to know the reason for?

Anyhow, for mesa itself, it seems reasonable to assign functions with
exactly the same argument signature to the appropriate driver function pointers.

This one as well as the other two warning fixes:
Reviewed-by: Mathias Fröhlich <Mathias.Froehlich at web.de>


More information about the mesa-dev mailing list