[Mesa-dev] [PATCH] radv: do not support blitting surfaces with depth and stencil

Samuel Pitoiset samuel.pitoiset at gmail.com
Tue Sep 18 13:06:42 UTC 2018


Fixes:
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.depth_stencil.d32_sfloat_s8_uint_d32_sfloat_s8_uint.optimal_optimal_nearest

And all friends that try to blit a surface with different
depth and stencil formats.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/vulkan/radv_formats.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
index e1b4b5e830..ad06c9e996 100644
--- a/src/amd/vulkan/radv_formats.c
+++ b/src/amd/vulkan/radv_formats.c
@@ -645,6 +645,10 @@ radv_physical_device_get_format_properties(struct radv_physical_device *physical
 			if (radv_is_filter_minmax_format_supported(format))
 				 tiled |= VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_MINMAX_BIT_EXT;
 
+			/* Don't support blitting surfaces with depth/stencil. */
+			if (vk_format_is_depth(format) && vk_format_is_stencil(format))
+				tiled &= ~VK_FORMAT_FEATURE_BLIT_DST_BIT;
+
 			/* Don't support linear depth surfaces */
 			linear = 0;
 		}
-- 
2.19.0



More information about the mesa-dev mailing list