[Mesa-dev] [PATCH 4/5] docs/meson: Update notes on using CFLAGS and -Dc_args

[Dylan Baker]

Quoting Eric Engestrom (2018-09-18 11:12:49)
> On Tuesday, 2018-09-18 09:13:03 -0700, Dylan Baker wrote:
> > bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107313
> > ---
> >  docs/meson.html | 28 ++++++++++++++--------------
> >  1 file changed, 14 insertions(+), 14 deletions(-)
> > 
> > diff --git a/docs/meson.html b/docs/meson.html
> > index e419d13e76d..1640e577d16 100644
> > --- a/docs/meson.html
> > +++ b/docs/meson.html
> > @@ -99,29 +99,29 @@ recommended in the documentation</a>
> >  <dt><code>Environment Variables</code></dt>
> >  <dd><p>Meson supports the standard CC and CXX environment variables for
> >  changing the default compiler, and CFLAGS, CXXFLAGS, and LDFLAGS for setting
> > -options to the compiler and linker.
> > +options to the compiler and linker durring the initial configuration.
> 
> s/durring/during/
> 
> >  
> > -The default compilers depends on your operating system. Meson supports most of
> > -the popular compilers, a complete list is available
> > -<a href="http://mesonbuild.com/Reference-tables.html#compiler-ids">here</a>.
> > -
> > -These arguments are consumed and stored by meson when it is initialized or
> > -re-initialized. Therefore passing them to meson configure will not do anything,
> > -and passing them to ninja will only do something if ninja decides to
> > -re-initialize meson, for example, if a meson.build file has been changed.
> > -Changing these variables will not cause all targets to be rebuilt, so running
> > -ninja clean is recommended when changing CFLAGS or CXXFLAGS. Meson will never
> > -change compiler in a configured build directory.
> > +These arguments are consumed and stored by meson when it is initialized. To
> > +change these flags after the build is initialized (or when doing a first
> > +initialization), consider using <code>-D$lang_args</code> and
> 
> How about {} around `lang` so that it's clear what is variable here?
> -D${lang}_args

Yes, that's much better. Normally I use <variable>, but html doesn't really like
that :)

> Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
> 
> > +<code>-D$lang_link_args</code> instead. Meson will never change compiler in a
> > +configured build directory.
> >  </p>
> >  
> >  <pre>
> >      CC=clang CXX=clang++ meson build-clang
> >      ninja -C build-clang
> >      ninja -C build-clang clean
> > -    touch meson.build
> > -    CFLAGS=-Wno-typedef-redefinition ninja -C build-clang
> > +    meson configure build -Dc_args="-Wno-typedef-redefinition"
> > +    ninja -C build-clang
> >  </pre>
> >  
> > +<p>
> > +The default compilers depends on your operating system. Meson supports most of
> > +the popular compilers, a complete list is available
> > +<a href="http://mesonbuild.com/Reference-tables.html#compiler-ids">here</a>.
> > +</p>
> > +
> >  <p>Meson also honors <code>DESTDIR</code> for installs</p>
> >  </dd>
> >  
> > -- 
> > 2.19.0
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180918/127b8a3a/attachment.sig>