[Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

[Michel Dänzer]

On 2018-09-19 1:10 p.m., Erik Faye-Lund wrote:
> On on., sep. 19, 2018 at 1:04 PM, Jakob Bornecrantz
> <wallbraker at gmail.com> wrote:
>> This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full
>> setup is dEQP running on virgl with vtest that is running RadeonSI. So
>> QEMU is not in the picture. All instances of the Mesa driver is from
>> the same tree and have the patch applied.
>>
>> Cheers, Jakob.
> 
> Hmm, that's a bit odd IMO. Perhaps a full flush is needed when clears
> are implemented using the graphics-pipeline or something? But I don't
> think virgl does this, so hmmm...
> 
> I guess I should revert, and try to respin with some more testing...

Please do. :) It also broke hundreds of piglits with radeonsi and
llvmpipe, presumably all Gallium drivers.


Maybe it's time to look into hooking up some CI testing with LLVM in
Gitlab. Any volunteers?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer