[Mesa-dev] [PATCH v2 5/5] gitlab-ci: use branch/tag in base image names

[Juan A. Suarez Romero]

On Tue, 2018-09-04 at 08:40 -0700, Eric Anholt wrote:
> "Juan A. Suarez Romero" <jasuarez at igalia.com> writes:
> 
> > To avoid conflicts with the base images when building two different
> > branches or tags at the same time, let's use different base/llvm image
> > names.
> > 
> > This way if both branches require different dependencies each one will
> > use its own base/llvm images.
> 
> Thinking of the future: if two of us are tweaking gitlab CI stuff in our
> personal branches and pushing to a branch named "test", will we be
> pushing into the same docker registry and overwriting each other?  Or do
> personal repos end up using different registries and that means that
> when a personal repo first does gitlab CI they always build their own
> images?
> 

If by "personal branch" you mean using your own repository, then there won't be
any problem, as you will have your own registry where the images are pushed.

The images name uses your personal name repository, and they are pushed to your
personal registry, and the gitlab CI will use this setup.
	
	J.A.



> These sorts of issues make me sort of prefer what I did for xserver,
> where docker image builds were entirely manual and we actually committed
> the reference to what docker image we wanted to build against in git.
> 
> Still, this seems like a necessary addition for the non-personal-repo
> case for now.
> 
> Acked-by: Eric Anholt <eric at anholt.net>