[Mesa-dev] [PATCH mesa 6/6] meson+autotools: get rid of spammy GCC warning -Wformat-truncation

Emil Velikov emil.l.velikov at gmail.com
Fri Sep 21 15:20:52 UTC 2018


On 21 September 2018 at 14:50, Eric Engestrom <eric.engestrom at intel.com> wrote:
> That warning fires every time a string function takes an argument that
> could possibly be longer than its max output, which triggers all over
> the place, especially when working with file paths ("what if every file
> path is MAX_PATH long?" is what GCC is saying, which is really annoying
> when we *know* that "/dev/dri/cardN" is not gonna be 4096 char long and
> it's safe to store it in a 32-char array).
>
> Anyway, we either add a ton of dead code all over the place to make GCC
> happy, or we get rid of its spam. I chose the latter.
>
This is my preference as well. Thanks

Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

-Emil


More information about the mesa-dev mailing list