[Mesa-dev] [PATCH v2 2/2] meson: swr: do a second llvm search with extra modules for llvm >= 7

[Chuck Atkins]

Hi Dylan,

I think you could simplify this:
>
> > +  if dep_llvm.found() and with_gallium_swr and
> dep_llvm.version().version_compare('>= 7')
> > +    _llvm_2pass = true
> > +    llvm_modules += ['ipo', 'objcarcopts']
> > +  endif
> > +  if _llvm_2pass
> > +    dep_llvm = dependency(
> > +      'llvm',
> > +      version : _llvm_version,
> > +      modules : llvm_modules,
> > +      optional_modules : llvm_optional_modules,
> > +      required : _llvm_req,
> > +    )
> > +  endif
>

> if dep_llvm.found() and with_gallium_swr and
> dep_llvm.version().version_compare('>= 7')
>   llvm_modules += ['ipo', 'objcarcopts']
>   dep_llvm = dependency(
>     'llvm',
>     version : _llvm_version,
>     modules : llvm_modules,
>     optional_modules : llvm_optional_modules,
>     required : _llvm_req,
>   )
> endif
> with_llvm = dep_llvm.found()
>

I could, and in fact, that exactly what I did initially.  But then I wanted
to explicitly seperate the second pass from the decision to do so making it
easy to allow other drivers to do something similar if needed in the same
spot.

- Chuck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180924/02075de7/attachment-0001.html>