[Mesa-dev] [PATCH 1/2] radv: disable complicated point clipping against user clip planes

Samuel Pitoiset samuel.pitoiset at gmail.com
Fri Sep 28 10:30:07 UTC 2018


I don't think this is required by Vulkan too.

Ported from RadeonSI (AMDVLK doesn't set it either).

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/vulkan/radv_pipeline.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index b49e6d2b2e..94688997b4 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -2708,7 +2708,6 @@ radv_pipeline_generate_raster_state(struct radeon_cmdbuf *cs,
 	uint32_t pa_sc_conservative_rast = 0;
 
 	radeon_set_context_reg(cs, R_028810_PA_CL_CLIP_CNTL,
-	                       S_028810_PS_UCP_MODE(3) |
 	                       S_028810_DX_CLIP_SPACE_DEF(1) | // vulkan uses DX conventions.
 	                       S_028810_ZCLIP_NEAR_DISABLE(vkraster->depthClampEnable ? 1 : 0) |
 	                       S_028810_ZCLIP_FAR_DISABLE(vkraster->depthClampEnable ? 1 : 0) |
-- 
2.19.0



More information about the mesa-dev mailing list