[Mesa-dev] Commit 'gallium: fix autotools build of pipe_msm.la' broke Clover - bisected

[Dieter Nützel]

Hello,

commit #356ec7a2196 'gallium: fix autotools build of pipe_msm.la' broke 
Clover.

biseted:
356ec7a21960d77db282f67af577dcdb46966b5a is the first bad commit
commit 356ec7a21960d77db282f67af577dcdb46966b5a
Author: Timur Kristóf <timur.kristof at gmail.com>
Date:   Thu Mar 14 15:32:37 2019 +0100

     gallium: fix autotools build of pipe_msm.la

     Signed-off-by: Vinson Lee <vlee at freedesktop.org>
     Fixes: 9a834447d652 ("tgsi_to_nir: Produce optimized NIR for a given 
pipe_screen.")
     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109929

:040000 040000 601ddeba6f98a1872a8f49667c89224601afe31b 
cee6467ed172beb890455d0874a2e883e6c95e14 M src

Reverting it bring Clover back.


The most annoying thing for me is, that even 'meson build' of Clover do 
NOT work for me (hello Dylan? ;-)):

../src/gallium/state_trackers/clover/api/event.cpp: In function ‘cl_int 
clGetEventProfilingInfo(cl_event, cl_profiling_info, size_t, void*, 
size_t*)’:
../src/gallium/state_trackers/clover/api/event.cpp:256:58: error: 
‘dynamic_cast’ not permitted with -fno-rtti
     hard_event &hev = dynamic_cast<hard_event &>(obj(d_ev));
                                                           ^
../src/gallium/state_trackers/clover/api/event.cpp:287:23: warning: 
ignoring attributes on template argument ‘cl_ulong’ {aka ‘long unsigned 
int’} [-Wignored-attributes]
  } catch (lazy<cl_ulong>::undefined_error &e) {
                        ^
In file included from 
../src/gallium/state_trackers/clover/core/event.hpp:29,
                  from 
../src/gallium/state_trackers/clover/api/event.cpp:24:
../src/gallium/state_trackers/clover/core/object.hpp: In instantiation 
of ‘static void clover::detail::descriptor_traits<T, D>::validate(D*) 
[with T = clover::soft_event; D = _cl_event]’:
../src/gallium/state_trackers/clover/core/object.hpp:148:48:   required 
from ‘typename clover::detail::descriptor_traits<T, D>::object_type& 
clover::obj(D*) [with T = clover::soft_event; D = _cl_event; typename 
clover::detail::descriptor_traits<T, D>::object_type = 
clover::soft_event]’
../src/gallium/state_trackers/clover/api/event.cpp:42:36:   required 
from here
../src/gallium/state_trackers/clover/core/object.hpp:72:18: error: 
‘dynamic_cast’ not permitted with -fno-rtti
                  !dynamic_cast<object_type *>(o))
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

meson config:
meson ../ --strip --buildtype debugoptimized -Ddri-drivers= 
-Dplatforms=drm,x11 -Dgallium-drivers=r600,radeonsi,swrast 
-Dvulkan-drivers=amd -Dgallium-nine=true -Dgallium-opencl=icd 
-Dglvnd=true -Dgallium-va=false -Dgallium-xvmc=false 
-Dgallium-omx=disabled -Dgallium-xa=false

Only -Dgallium-opencl=disabled works.

Thanks,
Dieter