[Mesa-dev] [PATCH 3/3] gallium/auxiliary/vl: Add barrier/unbind after compute shader launch.

[Marek Olšák]

On Tue, Apr 2, 2019 at 2:22 PM Zhu, James <James.Zhu at amd.com> wrote:

> Add memory barrier sync and unbind resource after launch will enhance
> the robustness.
>
> Signed-off-by: James Zhu <James.Zhu at amd.com>
> ---
>  src/gallium/auxiliary/vl/vl_compositor_cs.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/src/gallium/auxiliary/vl/vl_compositor_cs.c
> b/src/gallium/auxiliary/vl/vl_compositor_cs.c
> index c3afe61..f00cb65 100644
> --- a/src/gallium/auxiliary/vl/vl_compositor_cs.c
> +++ b/src/gallium/auxiliary/vl/vl_compositor_cs.c
> @@ -292,6 +292,17 @@ cs_launch(struct vl_compositor *c,
>     info.grid[2] = 1;
>
>     ctx->launch_grid(ctx, &info);
> +
> +   /* Make the result visible to all clients. */
> +   ctx->memory_barrier(ctx, PIPE_BARRIER_ALL);
> +
> +   /* Unbind. */
> +   ctx->set_shader_images(ctx, PIPE_SHADER_COMPUTE, 0, 1, NULL);
> +   ctx->set_constant_buffer(ctx, PIPE_SHADER_COMPUTE, 0, NULL);
> +   ctx->set_sampler_views(c->pipe, PIPE_SHADER_FRAGMENT, 0, 0, NULL);
>

count shouldn't be 0


> +   ctx->bind_compute_state(ctx, NULL);
> +   ctx->bind_sampler_states(c->pipe, PIPE_SHADER_COMPUTE, 0, 0, NULL);
>

same here

+   ctx->flush(ctx, NULL, 0);
>

the flush shouldn't be needed

Marek


>  }
>
>  static inline struct u_rect
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190403/b8b183fe/attachment.html>