[Mesa-dev] [PATCH 4/4] panfrost: Add T860 counters

[Boris Brezillon]

On Thu, 4 Apr 2019 08:55:24 -0700
Alyssa Rosenzweig <alyssa at rosenzweig.io> wrote:

> I sure hope you have a way of automatically generating these ^_^ 

Definitely. Didn't focus on that so far, but defining them in an XML
(or whatever) and generating .c/.h files out of it should be doable.

> 
> One fleeting thought is that some of the counters have "scales"
> attached, where the logical value we need to report back is some
> specified integer multiple of what the hardware actually writes. I don't
> know if we want to account for this, but it's in the XML
> files in gator.

Good question. I'd be in favor of keeping the driver as dump as
possible and letting counter users get something useful out of the
value, but it's not like applying a scale is super complicated. I'll
have a look at the XML files, thanks for the pointer.

> 
> Also, in case it's not already in that header, this needs to be
> Copyright (C) Arm Limited as well, see the file you got the definitions
> from for the years.

Will add ARM's copyright.

> 
> It's probably best to isolate the counter definitions into their own
> file, since there will be a -lot- of them and you don't want to clutter
> up the general performance counter headers.

I agree.

> 
> Aside from these thoughts, R-B :)