[Mesa-dev] [Bug 110348] radv: Resolve attachments do not work if view format differs from image format

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110348

            Bug ID: 110348
           Summary: radv: Resolve attachments do not work if view format
                    differs from image format
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Vulkan/radeon
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: philip.rebohle at tu-dortmund.de
        QA Contact: mesa-dev at lists.freedesktop.org

Created attachment 143889
  --> https://bugs.freedesktop.org/attachment.cgi?id=143889&action=edit
Probably incomplete fix

Hello,

using resolve attachments where the image view format differs from the actual
image format sometimes leads to incorrect or garbled results. The following
renderdoc capture (recorded on Polaris 10) shows one such example:

https://mega.nz/#!FeoBSKBS!AaXSH5e_VTs05s7_xStBVB-ptbl-C_lGx7854Apel8o

Here, the image format is R16G16B16A16_UNORM, while the view format is
R16G16B16A16_SFLOAT. The resolved image is garbled.

Playing around in the code, I observed the following:
- The HW path is the one that's used here and produces the broken image.
- The CS path works, but interprets image data using the image format, not the
view format.
- The FS path works and uses the view format.

The attached patch fixes the problem for this sample, but more work is likely
needed since radv_pick_resolve_method_images currently only takes the image
format into account as well.

I'm also not sure which format should actually be used for the resolve
operation; both AMDVLK and Nvidia use the image format and not the view format,
which is not what I need, and it doesn't look like the Vulkan spec actually
defines this.

- Philip

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190407/3f10a81d/attachment.html>