[Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

[Emil Velikov]

On Fri, 5 Apr 2019 at 14:57, Mathias Fröhlich <Mathias.Froehlich at gmx.net> wrote:
>
> Hi Emil,
>
> Now that I have been putting together a test case for the the actual use
> I do see some issues with the pbuffer code path. Well - still investigating
> if the test is wrong or the result.
>
Actually I do recall some issues with surfaceless (which is
practically identical to this code) and some (with alpha?) formats.
My memory is pretty flaky - I would suggest trying various configs:
with, w/o alpha, 32/24 etc.

> In the mean time some small comments inline below ...
>
> Mathias
>

> > --- a/src/egl/Android.mk
> > +++ b/src/egl/Android.mk
> > @@ -36,6 +36,7 @@ include $(CLEAR_VARS)
> >  LOCAL_SRC_FILES := \
> >       $(LIBEGL_C_FILES) \
> >       $(dri2_backend_core_FILES) \
> > +     drivers/dri2/platform_android.c \
> >       drivers/dri2/platform_android.c
>
> That one duplicates the file.
> The hunk is probably no longer needed?
>
That should have been "platform_device.c" - fixed locally.

> > +   /* Extension requires a PlatformDisplay - the EGLDevice. */
> > +   dev = disp->PlatformDisplay;
> > +   if (_eglDeviceSupports(dev, _EGL_DEVICE_DRM)) {
> > +      if (!disp->Options.ForceSoftware)
>
> if (disp->Options.ForceSoftware)
>
> The '!' in your code appears wrong to me.
>
Indeed it does. Fixed locally.

Thanks
Emil