[Mesa-dev] [PATCH 0/4] RadeonSI: Upload constants to VRAM via SDMA

Tue Apr 9 02:32:39 UTC 2019

Am 09.04.2019 02:42, schrieb Marek Olšák:
> I'm pretty sure I merged this series in February.
> 
> Marek

Yes, of course you did (with my tb), but I meant... (see below)

> On Mon, Apr 8, 2019 at 6:10 PM Dieter Nützel <Dieter at nuetzel-hh.de>
> wrote:
> 
>> Maybe someone working on this, too.
>> 
>> I'm feeling fine again after a short 'trip' into the hospital...;-)
>> 
>> Dieter
>> 
>> Am 26.02.2019 07:36, schrieb Marek Olšák:
>>> We need to extend the CS ioctl to allow submitting 2 command
>> buffers
>>> at the same time.

This additional work.

Dieter

>>> Marek
>>> 
>>> On Mon, Feb 25, 2019, 10:06 PM Dieter Nützel
>> <Dieter at nuetzel-hh.de>
>>> wrote:
>>> 
>>>> Hello Marek,
>>>> 
>>>> you wrote with your series sent:
>>>> 
>>>> [-]
>>>> Trivial benchmarks such as glxgears can expect 20% decrease
>>>> in performance due to the added cost of the SDMA CS ioctl that
>>>> wasn't
>>>> there before.
>>>> [-]
>>>> 
>>>> Any ideas to speed this up, again?
>>>> glmark2 went from 9766 (best ever) down to 7455 (all with NIR).
>>>> Or are micro benchmarks not worth more effort?
>>>> 
>>>> Dieter
>>>> 
>>>> SDMA
>>>> =======================================================
>>>> glmark2 2017.07
>>>> =======================================================
>>>> OpenGL Information
>>>> GL_VENDOR:     X.Org
>>>> GL_RENDERER:   Radeon RX 580 Series (POLARIS10, DRM 3.30.0,
>>>> 5.0.0-rc1-1.g7262353-default+, LLVM 9.0.0)
>>>> GL_VERSION:    4.5 (Compatibility Profile) Mesa 19.1.0-devel
>>>> (git-a9b32aaa16)
>>>> =======================================================
>>>> [build] use-vbo=false: FPS: 3694 FrameTime: 0.271 ms
>>>> [build] use-vbo=true: FPS: 9341 FrameTime: 0.107 ms
>>>> [texture] texture-filter=nearest: FPS: 9140 FrameTime: 0.109 ms
>>>> [texture] texture-filter=linear: FPS: 9163 FrameTime: 0.109 ms
>>>> [texture] texture-filter=mipmap: FPS: 9161 FrameTime: 0.109 ms
>>>> [shading] shading=gouraud: FPS: 9234 FrameTime: 0.108 ms
>>>> [shading] shading=blinn-phong-inf: FPS: 9255 FrameTime: 0.108 ms
>>>> [shading] shading=phong: FPS: 9226 FrameTime: 0.108 ms
>>>> [shading] shading=cel: FPS: 9310 FrameTime: 0.107 ms
>>>> [bump] bump-render=high-poly: FPS: 9298 FrameTime: 0.108 ms
>>>> [bump] bump-render=normals: FPS: 9121 FrameTime: 0.110 ms
>>>> [bump] bump-render=height: FPS: 9120 FrameTime: 0.110 ms
>>>> libpng warning: iCCP: known incorrect sRGB profile
>>>> [effect2d] kernel=0,1,0;1,-4,1;0,1,0;: FPS: 9858 FrameTime: 0.101
>> ms
>>>> libpng warning: iCCP: known incorrect sRGB profile
>>>> [effect2d] kernel=1,1,1,1,1;1,1,1,1,1;1,1,1,1,1;: FPS: 9854
>>>> FrameTime:
>>>> 0.101 ms
>>>> [pulsar] light=false:quads=5:texture=false: FPS: 8468 FrameTime:
>>>> 0.118
>>>> ms
>>>> libpng warning: iCCP: known incorrect sRGB profile
>>>> [desktop]
>>>> blur-radius=5:effect=blur:passes=1:separable=true:windows=4:
>>>> FPS: 5181 FrameTime: 0.193 ms
>>>> libpng warning: iCCP: known incorrect sRGB profile
>>>> [desktop] effect=shadow:windows=4: FPS: 5374 FrameTime: 0.186 ms
>>>> [buffer]
>>>> 
>>> 
>> 
> columns=200:interleave=false:update-dispersion=0.9:update-fraction=0.5:update-method=map:
>>>> 
>>>> FPS: 824 FrameTime: 1.214 ms
>>>> [buffer]
>>>> 
>>> 
>> 
> columns=200:interleave=false:update-dispersion=0.9:update-fraction=0.5:update-method=subdata:
>>>> 
>>>> FPS: 1114 FrameTime: 0.898 ms
>>>> [buffer]
>>>> 
>>> 
>> 
> columns=200:interleave=true:update-dispersion=0.9:update-fraction=0.5:update-method=map:
>>>> 
>>>> FPS: 899 FrameTime: 1.112 ms
>>>> [ideas] speed=duration: FPS: 3485 FrameTime: 0.287 ms
>>>> [jellyfish] <default>: FPS: 7992 FrameTime: 0.125 ms
>>>> [terrain] <default>: FPS: 1796 FrameTime: 0.557 ms
>>>> [shadow] <default>: FPS: 7350 FrameTime: 0.136 ms
>>>> [refract] <default>: FPS: 3595 FrameTime: 0.278 ms
>>>> [conditionals] fragment-steps=0:vertex-steps=0: FPS: 9401
>> FrameTime:
>>>> 
>>>> 0.106 ms
>>>> [conditionals] fragment-steps=5:vertex-steps=0: FPS: 9413
>> FrameTime:
>>>> 
>>>> 0.106 ms
>>>> [conditionals] fragment-steps=0:vertex-steps=5: FPS: 9417
>> FrameTime:
>>>> 
>>>> 0.106 ms
>>>> [function] fragment-complexity=low:fragment-steps=5: FPS: 9365
>>>> FrameTime: 0.107 ms
>>>> [function] fragment-complexity=medium:fragment-steps=5: FPS: 9451
>>>> FrameTime: 0.106 ms
>>>> [loop] fragment-loop=false:fragment-steps=5:vertex-steps=5: FPS:
>>>> 9300
>>>> FrameTime: 0.108 ms
>>>> [loop] fragment-steps=5:fragment-uniform=false:vertex-steps=5:
>> FPS:
>>>> 9440
>>>> FrameTime: 0.106 ms
>>>> [loop] fragment-steps=5:fragment-uniform=true:vertex-steps=5:
>> FPS:
>>>> 9392
>>>> FrameTime: 0.106 ms
>>>> =======================================================
>>>> glmark2 Score: 7455
>>>> =======================================================
>>>> 
>>>> Before
>>>> =======================================================
>>>> glmark2 2017.07
>>>> =======================================================
>>>> OpenGL Information
>>>> GL_VENDOR:     X.Org
>>>> GL_RENDERER:   Radeon RX 580 Series (POLARIS10, DRM 3.27.0,
>>>> 4.20.0-rc3-1.g7262353-default+, LLVM 8.0.0)
>>>> GL_VERSION:    4.5 (Compatibility Profile) Mesa 19.0.0-devel
>>>> (git-c49b3df3cb)
>>>> =======================================================
>>>> [build] use-vbo=false: FPS: 3373 FrameTime: 0.296 ms
>>>> [build] use-vbo=true: FPS: 13121 FrameTime: 0.076 ms
>>>> [texture] texture-filter=nearest: FPS: 12172 FrameTime: 0.082 ms
>>>> [texture] texture-filter=linear: FPS: 12557 FrameTime: 0.080 ms
>>>> [texture] texture-filter=mipmap: FPS: 12228 FrameTime: 0.082 ms
>>>> [shading] shading=gouraud: FPS: 12536 FrameTime: 0.080 ms
>>>> [shading] shading=blinn-phong-inf: FPS: 12782 FrameTime: 0.078 ms
>>>> [shading] shading=phong: FPS: 12619 FrameTime: 0.079 ms
>>>> [shading] shading=cel: FPS: 12735 FrameTime: 0.079 ms
>>>> [bump] bump-render=high-poly: FPS: 11412 FrameTime: 0.088 ms
>>>> [bump] bump-render=normals: FPS: 12467 FrameTime: 0.080 ms
>>>> [bump] bump-render=height: FPS: 12422 FrameTime: 0.081 ms
>>>> libpng warning: iCCP: known incorrect sRGB profile
>>>> [effect2d] kernel=0,1,0;1,-4,1;0,1,0;: FPS: 13252 FrameTime:
>> 0.075
>>>> ms
>>>> libpng warning: iCCP: known incorrect sRGB profile
>>>> [effect2d] kernel=1,1,1,1,1;1,1,1,1,1;1,1,1,1,1;: FPS: 11468
>>>> FrameTime:
>>>> 0.087 ms
>>>> [pulsar] light=false:quads=5:texture=false: FPS: 11385 FrameTime:
>>>> 0.088
>>>> ms
>>>> libpng warning: iCCP: known incorrect sRGB profile
>>>> [desktop]
>>>> blur-radius=5:effect=blur:passes=1:separable=true:windows=4:
>>>> FPS: 5609 FrameTime: 0.178 ms
>>>> libpng warning: iCCP: known incorrect sRGB profile
>>>> [desktop] effect=shadow:windows=4: FPS: 5944 FrameTime: 0.168 ms
>>>> [buffer]
>>>> 
>>> 
>> 
> columns=200:interleave=false:update-dispersion=0.9:update-fraction=0.5:update-method=map:
>>>> 
>>>> FPS: 837 FrameTime: 1.195 ms
>>>> [buffer]
>>>> 
>>> 
>> 
> columns=200:interleave=false:update-dispersion=0.9:update-fraction=0.5:update-method=subdata:
>>>> 
>>>> FPS: 1153 FrameTime: 0.867 ms
>>>> [buffer]
>>>> 
>>> 
>> 
> columns=200:interleave=true:update-dispersion=0.9:update-fraction=0.5:update-method=map:
>>>> 
>>>> FPS: 925 FrameTime: 1.081 ms
>>>> [ideas] speed=duration: FPS: 3042 FrameTime: 0.329 ms
>>>> [jellyfish] <default>: FPS: 10209 FrameTime: 0.098 ms
>>>> [terrain] <default>: FPS: 1791 FrameTime: 0.558 ms
>>>> [shadow] <default>: FPS: 9248 FrameTime: 0.108 ms
>>>> [refract] <default>: FPS: 3502 FrameTime: 0.286 ms
>>>> [conditionals] fragment-steps=0:vertex-steps=0: FPS: 13061
>>>> FrameTime:
>>>> 0.077 ms
>>>> [conditionals] fragment-steps=5:vertex-steps=0: FPS: 13225
>>>> FrameTime:
>>>> 0.076 ms
>>>> [conditionals] fragment-steps=0:vertex-steps=5: FPS: 12882
>>>> FrameTime:
>>>> 0.078 ms
>>>> [function] fragment-complexity=low:fragment-steps=5: FPS: 12806
>>>> FrameTime: 0.078 ms
>>>> [function] fragment-complexity=medium:fragment-steps=5: FPS:
>> 12936
>>>> FrameTime: 0.077 ms
>>>> [loop] fragment-loop=false:fragment-steps=5:vertex-steps=5: FPS:
>>>> 12954
>>>> FrameTime: 0.077 ms
>>>> [loop] fragment-steps=5:fragment-uniform=false:vertex-steps=5:
>> FPS:
>>>> 12788 FrameTime: 0.078 ms
>>>> [loop] fragment-steps=5:fragment-uniform=true:vertex-steps=5:
>> FPS:
>>>> 12846
>>>> FrameTime: 0.078 ms
>>>> =======================================================
>>>> glmark2 Score: 9766
>>>> =======================================================