[Mesa-dev] [PATCH] Partially revert "gallium: fix autotools build of pipe_msm.la"

Jan Vesely jan.vesely at rutgers.edu
Tue Apr 9 20:19:56 UTC 2019


On Sat, Apr 6, 2019 at 10:11 PM Dieter Nützel <Dieter at nuetzel-hh.de> wrote:
>
> Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
> Acked-by: Dieter Nützel <Dieter at nuetzel-hh.de>

Thanks Dieter,

Timur, Vinson, are you OK with this temporary solution?

Jan

>
> Thank you Jan!
>
> BTW More about 'meson' with radeonsi and Clover in some hours.
>
> Dieter
>
> Am 06.04.2019 06:43, schrieb Jan Vesely:
> > This partially reverts commit 356ec7a21960d77db282f67af577dcdb46966b5a.
> > There are missing symbols needed by libglsl, so we might as well skip
> > the entire library (which should be present in the mesa stat tracker).
> >
> > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > ---
> >
> > Hi Timur, Vinson,
> >
> > this patch is enough to get clover working again in autotools build,
> > until a proper solution lands (which should reinstate -Wl,-no-undefined
> > for pipe drivers).
> > Vinson, I tested freedreno and it builds, but I don't have hw to test
> > anything more, let me know if things still work or you with this patch.
> >
> > regards,
> > Jan
> >
> >  src/gallium/targets/pipe-loader/Makefile.am | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/gallium/targets/pipe-loader/Makefile.am
> > b/src/gallium/targets/pipe-loader/Makefile.am
> > index 807a100a7d0..864ee8d50d3 100644
> > --- a/src/gallium/targets/pipe-loader/Makefile.am
> > +++ b/src/gallium/targets/pipe-loader/Makefile.am
> > @@ -53,7 +53,8 @@ endif
> >
> >  PIPE_LIBS += \
> >       $(top_builddir)/src/gallium/auxiliary/libgallium.la \
> > -     $(top_builddir)/src/compiler/glsl/libglsl.la \
> > +     $(top_builddir)/src/compiler/nir/libnir.la \
> > +     $(top_builddir)/src/util/libmesautil.la \
> >       $(GALLIUM_COMMON_LIB_DEPS)
> >
> >  AM_LDFLAGS = \
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list