[Mesa-dev] [PATCH 10/10] ac/nir: remove some useless integer casts for ALU operations

[Timothy Arceri]

Before I attempt to review, have you run piglit on this series with 
radeonsi nir?

On 11/4/19 1:16 am, Samuel Pitoiset wrote:
> Sources are always casted to integers.
> 
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>   src/amd/common/ac_nir_to_llvm.c | 16 ----------------
>   1 file changed, 16 deletions(-)
> 
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 3dfcbacdef4..f1c082c1130 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -874,13 +874,11 @@ static void visit_alu(struct ac_nir_context *ctx, const nir_alu_instr *instr)
>   	case nir_op_i2f16:
>   	case nir_op_i2f32:
>   	case nir_op_i2f64:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
>   		result = LLVMBuildSIToFP(ctx->ac.builder, src[0], ac_to_float_type(&ctx->ac, def_type), "");
>   		break;
>   	case nir_op_u2f16:
>   	case nir_op_u2f32:
>   	case nir_op_u2f64:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
>   		result = LLVMBuildUIToFP(ctx->ac.builder, src[0], ac_to_float_type(&ctx->ac, def_type), "");
>   		break;
>   	case nir_op_f2f16_rtz:
> @@ -905,7 +903,6 @@ static void visit_alu(struct ac_nir_context *ctx, const nir_alu_instr *instr)
>   	case nir_op_u2u16:
>   	case nir_op_u2u32:
>   	case nir_op_u2u64:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
>   		if (ac_get_elem_bits(&ctx->ac, LLVMTypeOf(src[0])) < ac_get_elem_bits(&ctx->ac, def_type))
>   			result = LLVMBuildZExt(ctx->ac.builder, src[0], def_type, "");
>   		else
> @@ -915,7 +912,6 @@ static void visit_alu(struct ac_nir_context *ctx, const nir_alu_instr *instr)
>   	case nir_op_i2i16:
>   	case nir_op_i2i32:
>   	case nir_op_i2i64:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
>   		if (ac_get_elem_bits(&ctx->ac, LLVMTypeOf(src[0])) < ac_get_elem_bits(&ctx->ac, def_type))
>   			result = LLVMBuildSExt(ctx->ac.builder, src[0], def_type, "");
>   		else
> @@ -925,25 +921,18 @@ static void visit_alu(struct ac_nir_context *ctx, const nir_alu_instr *instr)
>   		result = emit_bcsel(&ctx->ac, src[0], src[1], src[2]);
>   		break;
>   	case nir_op_find_lsb:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
>   		result = ac_find_lsb(&ctx->ac, ctx->ac.i32, src[0]);
>   		break;
>   	case nir_op_ufind_msb:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
>   		result = ac_build_umsb(&ctx->ac, src[0], ctx->ac.i32);
>   		break;
>   	case nir_op_ifind_msb:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
>   		result = ac_build_imsb(&ctx->ac, src[0], ctx->ac.i32);
>   		break;
>   	case nir_op_uadd_carry:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
> -		src[1] = ac_to_integer(&ctx->ac, src[1]);
>   		result = emit_uint_carry(&ctx->ac, "llvm.uadd.with.overflow.i32", src[0], src[1]);
>   		break;
>   	case nir_op_usub_borrow:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
> -		src[1] = ac_to_integer(&ctx->ac, src[1]);
>   		result = emit_uint_carry(&ctx->ac, "llvm.usub.with.overflow.i32", src[0], src[1]);
>   		break;
>   	case nir_op_b2f16:
> @@ -961,20 +950,15 @@ static void visit_alu(struct ac_nir_context *ctx, const nir_alu_instr *instr)
>   		result = emit_b2i(&ctx->ac, src[0], instr->dest.dest.ssa.bit_size);
>   		break;
>   	case nir_op_i2b32:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
>   		result = emit_i2b(&ctx->ac, src[0]);
>   		break;
>   	case nir_op_fquantize2f16:
>   		result = emit_f2f16(&ctx->ac, src[0]);
>   		break;
>   	case nir_op_umul_high:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
> -		src[1] = ac_to_integer(&ctx->ac, src[1]);
>   		result = emit_umul_high(&ctx->ac, src[0], src[1]);
>   		break;
>   	case nir_op_imul_high:
> -		src[0] = ac_to_integer(&ctx->ac, src[0]);
> -		src[1] = ac_to_integer(&ctx->ac, src[1]);
>   		result = emit_imul_high(&ctx->ac, src[0], src[1]);
>   		break;
>   	case nir_op_pack_half_2x16:
>