[Mesa-dev] [PATCH 1/2] draw: fix undefined shift of (1 << 31)

Dave Airlie airlied at gmail.com
Thu Apr 11 10:32:18 UTC 2019


From: Dave Airlie <airlied at redhat.com>

Pointed out by a coverity scan.
---
 src/gallium/auxiliary/draw/draw_pipe_aapoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/draw/draw_pipe_aapoint.c b/src/gallium/auxiliary/draw/draw_pipe_aapoint.c
index 2b96b8ad446..dc22039b127 100644
--- a/src/gallium/auxiliary/draw/draw_pipe_aapoint.c
+++ b/src/gallium/auxiliary/draw/draw_pipe_aapoint.c
@@ -175,7 +175,7 @@ aa_transform_prolog(struct tgsi_transform_context *ctx)
 
    /* find two free temp regs */
    for (i = 0; i < 32; i++) {
-      if ((aactx->tempsUsed & (1 << i)) == 0) {
+      if ((aactx->tempsUsed & (1u << i)) == 0) {
          /* found a free temp */
          if (aactx->tmp0 < 0)
             aactx->tmp0 = i;
-- 
2.20.1



More information about the mesa-dev mailing list