[Mesa-dev] [PATCH 2/2] intel/compiler: fix uninit non-static variable.

Lionel Landwerlin lionel.g.landwerlin at intel.com
Thu Apr 11 12:25:17 UTC 2019


To be honest we're not initializing nir_locals either :/

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 11/04/2019 11:32, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> Pointed out by coverity.
> ---
>   src/intel/compiler/brw_vec4_visitor.cpp | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/intel/compiler/brw_vec4_visitor.cpp b/src/intel/compiler/brw_vec4_visitor.cpp
> index 16ee31d730a..fa3d7fc13b7 100644
> --- a/src/intel/compiler/brw_vec4_visitor.cpp
> +++ b/src/intel/compiler/brw_vec4_visitor.cpp
> @@ -1887,6 +1887,8 @@ vec4_visitor::vec4_visitor(const struct brw_compiler *compiler,
>      this->max_grf = devinfo->gen >= 7 ? GEN7_MRF_HACK_START : BRW_MAX_GRF;
>   
>      this->uniforms = 0;
> +
> +   this->nir_ssa_values = NULL;
>   }
>   
>   




More information about the mesa-dev mailing list