[Mesa-dev] [PATCH] ac/nir_to_llvm: use correct intrinsic type for bindless atomic_{min, max}

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Mon Apr 15 09:12:20 UTC 2019


r-b

On Mon, Apr 15, 2019 at 2:17 AM Timothy Arceri <tarceri at itsqueeze.com> wrote:
>
> Coverity: CID 1444664
>
> Fixes: d62d434fe920 ("ac/nir_to_llvm: add image bindless support")
> ---
>  src/amd/common/ac_nir_to_llvm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 61b33c74e6c..8266e7e9f68 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -2549,8 +2549,8 @@ static LLVMValueRef visit_image_atomic(struct ac_nir_context *ctx,
>         bool is_unsigned;
>         bool is_array;
>         if (bindless) {
> -               if (instr->intrinsic == nir_intrinsic_image_atomic_min ||
> -                   instr->intrinsic == nir_intrinsic_image_atomic_max) {
> +               if (instr->intrinsic == nir_intrinsic_bindless_image_atomic_min ||
> +                   instr->intrinsic == nir_intrinsic_bindless_image_atomic_max) {
>                         const GLenum format = nir_intrinsic_format(instr);
>                         assert(format == GL_R32UI || format == GL_R32I);
>                         is_unsigned = format == GL_R32UI;
> --
> 2.20.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list