[Mesa-dev] [PATCH 01/19] panfrost/mdg/disasm: Print raw varying_parameters

Alyssa Rosenzweig alyssa at rosenzweig.io
Mon Apr 22 05:04:08 UTC 2019


The semantics of this field are not well understood; it is better to
print it unconditionally along with the other unknown state, rather than
silently eat the value. Without this change, some critical state was
being lost in some shaders (notably, the offset for load/store
scratchpad intructions found in shaders that spill registers.)

Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
---
 src/gallium/drivers/panfrost/midgard/disassemble.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/panfrost/midgard/disassemble.c b/src/gallium/drivers/panfrost/midgard/disassemble.c
index e9ff3808318..21a01aa9b0e 100644
--- a/src/gallium/drivers/panfrost/midgard/disassemble.c
+++ b/src/gallium/drivers/panfrost/midgard/disassemble.c
@@ -759,7 +759,7 @@ print_load_store_instr(uint64_t data,
 
         print_swizzle(word->swizzle);
 
-        printf(", 0x%X\n", word->unknown);
+        printf(", 0x%X /* %X */\n", word->unknown, word->varying_parameters);
 }
 
 static void
-- 
2.20.1



More information about the mesa-dev mailing list