[Mesa-dev] [PATCH] radv: increase aligment when allocating descriptors for meta operations

[Samuel Pitoiset]

Please ignore this fix, it's incorrect and we shouldn't have to increase 
alignment.

On 3/7/19 11:43 AM, Samuel Pitoiset wrote:
> We usually align to 0x100 when allocating descriptors and
> resources in the upload BO. I assume some data were corrupted
> because the alignment was too small. Be consistent (and safe)
> and align internal descriptors to 0x100 as well.
>
> This fixes a GPU hang at startup with X4 Foundations.
>
> Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>   src/amd/vulkan/radv_cmd_buffer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 5b66930d137..24ed6d47a51 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -2848,7 +2848,7 @@ void radv_meta_push_descriptor_set(
>   	push_set->size = layout->set[set].layout->size;
>   	push_set->layout = layout->set[set].layout;
>   
> -	if (!radv_cmd_buffer_upload_alloc(cmd_buffer, push_set->size, 32,
> +	if (!radv_cmd_buffer_upload_alloc(cmd_buffer, push_set->size, 256,
>   	                                  &bo_offset,
>   	                                  (void**) &push_set->mapped_ptr))
>   		return;