[Mesa-dev] Mesa (master): radeonsi: delay adding BOs at the beginning of IBs until the first draw

[Michel Dänzer]

On 2019-04-23 5:39 p.m., GitLab Mirror wrote:
> Module: Mesa
> Branch: master
> Commit: 951d60f8cdc886adff09201ff65002e3ee1a4c61
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=951d60f8cdc886adff09201ff65002e3ee1a4c61
> 
> Author: Marek Olšák <marek.olsak at amd.com>
> Date:   Wed Feb 27 21:13:15 2019 -0500
> 
> radeonsi: delay adding BOs at the beginning of IBs until the first draw
> 
> so that bound compute shader resources won't be added when they are not
> needed and same for graphics.
> 
> Acked-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

This broke a bunch of piglit tests for me with Bonaire (using the amdgpu
kernel driver), e.g. shaders at glsl-max-varyings:

Vertical axis: Increasing numbers of varyings.
Horizontal axis: Which of the varyings contains the color.
GL_MAX_VARYING_FLOATS = 128
Probe color at (2,2)
  Expected: 0 255 0
  Observed: 0 0 0
  Failure with 1 vec4 varyings used in varying index 0


-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer