[Mesa-dev] [PATCH 7/9] panfrost: Get rid of the skippable param in attach_vt_framebuffer()

Alyssa Rosenzweig alyssa.rosenzweig at collabora.com
Fri Aug 2 15:13:12 UTC 2019


R-b, I think.

On Fri, Aug 02, 2019 at 12:12:55PM +0200, Boris Brezillon wrote:
> The only user of this function always passes true.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
> ---
>  src/gallium/drivers/panfrost/pan_context.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c
> index 2b7906eea155..e781d809812b 100644
> --- a/src/gallium/drivers/panfrost/pan_context.c
> +++ b/src/gallium/drivers/panfrost/pan_context.c
> @@ -203,11 +203,11 @@ panfrost_attach_vt_sfbd(struct panfrost_context *ctx)
>  }
>  
>  static void
> -panfrost_attach_vt_framebuffer(struct panfrost_context *ctx, bool skippable)
> +panfrost_attach_vt_framebuffer(struct panfrost_context *ctx)
>  {
>          /* Skip the attach if we can */
>  
> -        if (skippable && ctx->payloads[PIPE_SHADER_VERTEX].postfix.framebuffer) {
> +        if (ctx->payloads[PIPE_SHADER_VERTEX].postfix.framebuffer) {
>                  assert(ctx->payloads[PIPE_SHADER_FRAGMENT].postfix.framebuffer);
>                  return;
>          }
> @@ -1013,7 +1013,7 @@ panfrost_emit_for_draw(struct panfrost_context *ctx, bool with_vertex_data)
>          struct panfrost_job *job = panfrost_get_job_for_fbo(ctx);
>          struct panfrost_screen *screen = pan_screen(ctx->base.screen);
>  
> -        panfrost_attach_vt_framebuffer(ctx, true);
> +        panfrost_attach_vt_framebuffer(ctx);
>  
>          if (with_vertex_data) {
>                  panfrost_emit_vertex_data(job);
> -- 
> 2.21.0
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190802/49be3390/attachment.sig>


More information about the mesa-dev mailing list