[Mesa-dev] [PATCH v2 5/5] panfrost: Print errors from kernel

[Tomeu Vizoso]

On Thu, 8 Aug 2019 at 00:52, Rob Herring <robh at kernel.org> wrote:
>
> On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso <tomeu.vizoso at collabora.com> wrote:
> >
> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
> > Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
> > ---
> >  src/gallium/drivers/panfrost/pan_drm.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c
> > index 71eda2d1e328..36a6b975680a 100644
> > --- a/src/gallium/drivers/panfrost/pan_drm.c
> > +++ b/src/gallium/drivers/panfrost/pan_drm.c
> > @@ -49,14 +49,14 @@ panfrost_drm_mmap_bo(struct panfrost_screen *screen, struct panfrost_bo *bo)
> >
> >          ret = drmIoctl(screen->fd, DRM_IOCTL_PANFROST_MMAP_BO, &mmap_bo);
> >          if (ret) {
> > -                fprintf(stderr, "DRM_IOCTL_PANFROST_MMAP_BO failed: %d\n", ret);
> > +                fprintf(stderr, "DRM_IOCTL_PANFROST_MMAP_BO failed: %m\n");
>
> Is this going to work on Android and bionic?

Yep: https://android.googlesource.com/platform/bionic/+/refs/heads/master/libc/stdio/vfprintf.cpp#455

Musl and uClibc also support it.

Cheers,

Tomeu

> stderr goes to /dev/null
> anyways on Android, so probably not a big deal.
>
> Rob
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev