[Mesa-dev] [PATCH] radeonsi: Bump number of allowed global buffers to 48 (again, for clover Blender assertion)

[Jan Vesely]

On Tue, 2019-08-06 at 23:20 -0400, Marek Olšák wrote:
> Do you know why global buffers are in the compute state and not in the
> context?

Not really. I mostly follow the existing design when it comes to mesa.
I'd assume it's a leftover from r600 which has limited number of cbufs
(and uses shared pool to accommodate global buffers).

cl global buffers are created in cl context so I think there shouldn't
be too much trouble moving it to the driver equivalent of that.

Jan

> 
> Marek
> 
> On Tue, Aug 6, 2019 at 10:50 PM Dieter Nützel <Dieter at nuetzel-hh.de> wrote:
> 
> > Am 20.06.2019 20:44, schrieb Jan Vesely:
> > > On Sat, 2019-06-15 at 07:38 +0200, Dieter Nützel wrote:
> > > > Am 14.06.2019 08:13, schrieb Jan Vesely:
> > > > > On Thu, 2019-06-13 at 21:20 +0200, Dieter Nützel wrote:
> > > > > > Blender crash as expected ;-)
> > > > > > 
> > > > > > /home/dieter> trying to save userpref at
> > > > > > /home/dieter/.config/blender/2.79/config/userpref.blend ok
> > > > > > Read blend: /data/Blender/barbershop_interior_gpu.blend
> > > > > > scripts disabled for "/data/Blender/barbershop_interior_gpu.blend",
> > > > > > skipping 'generate_customprops.py'
> > > > > > skipping driver 'var', automatic scripts are disabled
> > > > > > skipping driver 'var', automatic scripts are disabled
> > > > > > skipping driver 'var', automatic scripts are disabled
> > > > > > skipping driver 'var', automatic scripts are disabled
> > > > > > skipping driver 'var', automatic scripts are disabled
> > > > > > skipping driver 'var', automatic scripts are disabled
> > > > > > skipping driver 'var', automatic scripts are disabled
> > > > > > skipping driver 'var', automatic scripts are disabled
> > > > > > skipping driver 'var', automatic scripts are disabled
> > > > > > Device init success
> > > > > > Compiling OpenCL program split
> > > > > > Kernel compilation of split finished in 8.41s.
> > > > > > 
> > > > > > Compiling OpenCL program base
> > > > > > Kernel compilation of base finished in 4.55s.
> > > > > > 
> > > > > > Compiling OpenCL program denoising
> > > > > > Kernel compilation of denoising finished in 2.08s.
> > > > > > 
> > > > > > blender: ../src/gallium/drivers/radeonsi/si_compute.c:319:
> > > > > > si_set_global_binding: Assertion `first + n <= MAX_GLOBAL_BUFFERS'
> > > > > > failed.
> > > > > > 
> > > > > > [1]    Abbruch                       blender (core dumped)
> > > > > 
> > > > > The number of max global buffers was bumped in 06bf56725d to fix
> > > > > similar crash in luxmark. I guess it needs another bump.
> > > > 
> > > > Hello Jan,
> > > > 
> > > > I'm so blind...
> > > > ...bumping it 48 and 64 (first try) works. 33 not ;-)
> > > > We shouldn't waste to much memory.
> > > 
> > > Feel free to post a patch. I'm not sure at which point Marek wants to
> > > switch to dynamic allocation (or if at all), but there's no limit in
> > > OCL so we might end up bumping this every time a new app pushes
> > > against the limit.
> > 
> > Hello Jan,
> > 
> > comming 'happily' from vacation and think we should've this in 19.2.
> > 
> > Marek,
> > 
> > do we need dynamic allocation, yet?
> > 
> > Sorry, please see attachment.
> > Would be nice, if someone of you could add these lines during commit:
> > 
> >      Fixes assertion failure/crash when running Blender (2.79b) on
> > clover.
> >      CC: mesa-stable at lists.freedesktop.org    <= ???
> > 
> > Greetings,
> > Dieter

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190808/e235de97/attachment.sig>