[Mesa-dev] [PATCH 2/2] panfrost: Add madvise support to BO cache

[Alyssa Rosenzweig]

I'm not one to care, but fwiw, spacing is inconsistent..?

> +			if (!ret && !madv.retained) {

What's the logic here? (What does a 0/!0 return code mean here?) I'm
wondering if this meant to be ||?

Or is the idea that an older kernel will have ret!=0 (since it doesn't
recognize the ioctl) and therefore BOs won't be released, whereas new
kernels will have ret==0 and then retained=0 if it needs to be released?
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190809/20b48d83/attachment.sig>