[Mesa-dev] [PATCH 1/2] panfrost: Don't use mir_foreach_instr_in_block_safe() when not needed

[Boris Brezillon]

On Tue, 13 Aug 2019 12:55:57 -0700
Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com> wrote:

> > +++ b/src/panfrost/midgard/midgard_opt_perspective.c
> > @@ -71,7 +71,7 @@ midgard_opt_combine_projection(compiler_context *ctx, midgard_block *block)
> >                  unsigned frcp_component = 0;
> >                  unsigned frcp_from = 0;
> >  
> > -                mir_foreach_instr_in_block_safe(block, sub) {
> > +                mir_foreach_instr_in_block(block, sub) {  
> 
> Should this one be _safe?

I don't see any remove_ins()/insert_before() call in there. Do you see
any reason for using the _safe() variant here?