[Mesa-dev] [PATCH] intel: Load the driver even if I915_PARAM_REVISION is not found.

[Lionel Landwerlin]

On 19/08/2019 21:28, Rafael Antognolli wrote:
> This param is only available starting on kernel 4.16. Use a default
> value of 0 if it is not found instead.


I trace the param to :


commit 27cd44618b92fc8c6889e4628407791e45422bac
Author: Neil Roberts <neil at linux.intel.com>
Date:   Wed Mar 4 14:41:16 2015 +0000

     drm/i915: Add I915_PARAM_REVISION


That seems to be back into 4.1. Could it be another issue?


-Lionel


>
> Cc: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Mark Janes <mark.a.janes at intel.com>
> ---
>   src/intel/dev/gen_device_info.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/dev/gen_device_info.c b/src/intel/dev/gen_device_info.c
> index 3953a1f4af3..375d13630a5 100644
> --- a/src/intel/dev/gen_device_info.c
> +++ b/src/intel/dev/gen_device_info.c
> @@ -1366,7 +1366,7 @@ gen_get_device_info_from_fd(int fd, struct gen_device_info *devinfo)
>         return false;
>   
>      if (!getparam(fd, I915_PARAM_REVISION, &devinfo->revision))
> -       return false;
> +      devinfo->revision = 0;
>   
>      if (!query_topology(devinfo, fd)) {
>         if (devinfo->gen >= 10) {