[Mesa-dev] [PATCH 4/4] scons: Make GCC builds stricter.

[Jose Fonseca]

Hi Michel,

> Good to see you guys starting to take better advantage of the GitLab CI pipeline.

Gitlab CI integration is complicated (very configurable), but I can tell from my experience with my own personal Github projects that having tests run during PRs are a god send.

> With my last name spelled correctly Dänzer or Daenzer,

Oops.  I worried about getting the "ae" right and forgot the "n"..  m(_ _)m

Jose

________________________________
From: Michel Dänzer <michel at daenzer.net>
Sent: Wednesday, August 28, 2019 11:59
To: Jose Fonseca <jfonseca at vmware.com>; Brian Paul <brianp at vmware.com>; Roland Scheidegger <sroland at vmware.com>; Charmaine Lee <charmainel at vmware.com>
Cc: mesa-dev at lists.freedesktop.org <mesa-dev at lists.freedesktop.org>; eric at engestrom.ch <eric at engestrom.ch>
Subject: Re: [Mesa-dev] [PATCH 4/4] scons: Make GCC builds stricter.

On 2019-08-27 12:57 p.m., Jose Fonseca wrote:
> Uses some of the same -Werror options used by Meson,

Cool stuff! Good to see you guys starting to take better advantage of
the GitLab CI pipeline.

> as suggested by Michel Daezer.

With my last name spelled correctly Dänzer or Daenzer,

Reviewed-by: Michel Dänzer <michel at daenzer.net>


--
Earthling Michel Dänzer               |               https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fredhat.com&data=02%7C01%7Cjfonseca%40vmware.com%7C00a1f6d6e4524f99fd1308d72ba6d5fe%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637025867896875073&sdata=FT3RG3hSCPhJe5Xdm3JIZ8gvSbjc6gbpsOIi0x3lMa4%3D&reserved=0
Libre software enthusiast             |             Mesa and X developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190828/f9fbbfbf/attachment-0001.html>