[Mesa-dev] [PATCH] egl/android: Enable HAL_PIXEL_FORMAT_RGBA_FP16 format

Tapani Pälli tapani.palli at intel.com
Thu Aug 29 10:43:24 UTC 2019


Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

On 8/29/19 12:18 AM, Nataraj Deshpande wrote:
> The patch adds support for 64 bit HAL_PIXEL_FORMAT_RGBA_FP16
> for android platform.
> 
> Fixes android.graphics.cts.BitmapColorSpaceTest#test16bitHardware
> which failed in egl due to "Unsupported native buffer format 0x16"
> on chromebooks.
> 
> Change-Id: I44f886fce27fe5f738d2dc229eed8b59088cf6d6
> Signed-off-by: Nataraj Deshpande <nataraj.deshpande at intel.com>
> ---
>   src/egl/drivers/dri2/platform_android.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c
> index 601b29e..97e7947 100644
> --- a/src/egl/drivers/dri2/platform_android.c
> +++ b/src/egl/drivers/dri2/platform_android.c
> @@ -109,6 +109,9 @@ get_format_bpp(int native)
>      int bpp;
>   
>      switch (native) {
> +   case HAL_PIXEL_FORMAT_RGBA_FP16:
> +      bpp = 8;
> +      break;
>      case HAL_PIXEL_FORMAT_RGBA_8888:
>      case HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED:
>         /*
> @@ -143,6 +146,7 @@ static int get_fourcc(int native)
>          * TODO: Remove this once https://issuetracker.google.com/32077885 is fixed.
>          */
>      case HAL_PIXEL_FORMAT_RGBX_8888: return __DRI_IMAGE_FOURCC_XBGR8888;
> +   case HAL_PIXEL_FORMAT_RGBA_FP16: return __DRI_IMAGE_FOURCC_ABGR16161616F;
>      default:
>         _eglLog(_EGL_WARNING, "unsupported native buffer format 0x%x", native);
>      }
> @@ -161,6 +165,7 @@ static int get_format(int format)
>          * TODO: Revert this once https://issuetracker.google.com/32077885 is fixed.
>          */
>      case HAL_PIXEL_FORMAT_RGBX_8888: return __DRI_IMAGE_FORMAT_XBGR8888;
> +   case HAL_PIXEL_FORMAT_RGBA_FP16: return __DRI_IMAGE_FORMAT_ABGR16161616F;
>      default:
>         _eglLog(_EGL_WARNING, "unsupported native buffer format 0x%x", format);
>      }
> 


More information about the mesa-dev mailing list