[Mesa-dev] [PATCH 3/4] panfrost: Pass a batch to panfrost_drm_submit_vs_fs_batch()
Boris Brezillon
boris.brezillon at collabora.com
Fri Aug 30 14:05:36 UTC 2019
Given the function name it makes more sense to pass it a job batch
directly.
Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
---
src/gallium/drivers/panfrost/pan_drm.c | 13 ++++++-------
src/gallium/drivers/panfrost/pan_job.c | 2 +-
src/gallium/drivers/panfrost/pan_screen.h | 2 +-
3 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c
index 3fea1274ca1a..e7f1b7225b4a 100644
--- a/src/gallium/drivers/panfrost/pan_drm.c
+++ b/src/gallium/drivers/panfrost/pan_drm.c
@@ -248,12 +248,12 @@ panfrost_drm_export_bo(struct panfrost_screen *screen, const struct panfrost_bo
}
static int
-panfrost_drm_submit_batch(struct panfrost_context *ctx, u64 first_job_desc,
+panfrost_drm_submit_batch(struct panfrost_job_batch *batch, u64 first_job_desc,
int reqs)
{
+ struct panfrost_context *ctx = batch->ctx;
struct pipe_context *gallium = (struct pipe_context *) ctx;
struct panfrost_screen *screen = pan_screen(gallium->screen);
- struct panfrost_job_batch *batch = panfrost_job_get_batch_for_fbo(ctx);
struct drm_panfrost_submit submit = {0,};
int *bo_handles, ret;
@@ -293,23 +293,22 @@ panfrost_drm_submit_batch(struct panfrost_context *ctx, u64 first_job_desc,
}
int
-panfrost_drm_submit_vs_fs_batch(struct panfrost_context *ctx, bool has_draws)
+panfrost_drm_submit_vs_fs_batch(struct panfrost_job_batch *batch, bool has_draws)
{
+ struct panfrost_context *ctx = batch->ctx;
int ret = 0;
- struct panfrost_job_batch *batch = panfrost_job_get_batch_for_fbo(ctx);
-
panfrost_job_add_bo(batch, ctx->scratchpad.bo);
panfrost_job_add_bo(batch, ctx->tiler_heap.bo);
panfrost_job_add_bo(batch, batch->polygon_list);
if (batch->first_job.gpu) {
- ret = panfrost_drm_submit_batch(ctx, batch->first_job.gpu, 0);
+ ret = panfrost_drm_submit_batch(batch, batch->first_job.gpu, 0);
assert(!ret);
}
if (batch->first_tiler.gpu || batch->clear) {
- ret = panfrost_drm_submit_batch(ctx,
+ ret = panfrost_drm_submit_batch(batch,
panfrost_fragment_job(ctx, has_draws),
PANFROST_JD_REQ_FS);
assert(!ret);
diff --git a/src/gallium/drivers/panfrost/pan_job.c b/src/gallium/drivers/panfrost/pan_job.c
index f9f02161d661..b308a1722c66 100644
--- a/src/gallium/drivers/panfrost/pan_job.c
+++ b/src/gallium/drivers/panfrost/pan_job.c
@@ -209,7 +209,7 @@ panfrost_job_submit(struct panfrost_context *ctx, struct panfrost_job_batch *bat
bool has_draws = batch->last_job.gpu;
- ret = panfrost_drm_submit_vs_fs_batch(ctx, has_draws);
+ ret = panfrost_drm_submit_vs_fs_batch(batch, has_draws);
if (ret)
fprintf(stderr, "panfrost_job_submit failed: %d\n", ret);
diff --git a/src/gallium/drivers/panfrost/pan_screen.h b/src/gallium/drivers/panfrost/pan_screen.h
index 15a88ac25569..c70f8bdd0507 100644
--- a/src/gallium/drivers/panfrost/pan_screen.h
+++ b/src/gallium/drivers/panfrost/pan_screen.h
@@ -165,7 +165,7 @@ panfrost_drm_import_bo(struct panfrost_screen *screen, int fd);
int
panfrost_drm_export_bo(struct panfrost_screen *screen, const struct panfrost_bo *bo);
int
-panfrost_drm_submit_vs_fs_batch(struct panfrost_context *ctx, bool has_draws);
+panfrost_drm_submit_vs_fs_batch(struct panfrost_job_batch *batch, bool has_draws);
void
panfrost_drm_force_flush_fragment(struct panfrost_context *ctx,
struct pipe_fence_handle **fence);
--
2.21.0
More information about the mesa-dev
mailing list