[Mesa-dev] Is it time to stop using the mailing list for patch review?

[Timothy Arceri]

On 11/12/19 8:54 am, Alex Deucher wrote:
> On Tue, Dec 10, 2019 at 1:13 PM Dylan Baker <dylan at pnwbakers.com> wrote:
>>
>> Do we have those and does anyone notice? I personally rarely look at the list
>> now unless I'm CC'd on something. That seems really bad for drive by
>> contributors.
>>
>> But frankly I wouldn't submit to a mailing list as a drive by, it's more work to
>> get subscribed to mail man (so my patch goes through), set up get-send-email,
>> and send the patches, then unsubscribe when I'm done than it would be to sign up
>> for gitlab.fdo using one of the "sign-in-with" options. If you're not subscribed
>> you go into limbo until a list maintainer approves your patch, and I think any
>> follow ups. That seems even worse as most people probably aren't aware of that
>> behavior. Maybe I'm the only one who feels that way though.
> 
> I've still seen a few.

The only ones I've seen recently are from some new ? AMD devs and a few 
patches from Jonathan Gray who is a long time contributor.

Having merge request run though basic CI before merging is enough reason 
to no longer suggest people use the mailing list for patch submission. 
I've created a MR to update the docs.

https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3045

>  Most drive by contributors generally don't
> subscribe to the list.  Since most lists are moderated, the mail
> usually makes it through whether they are subscribed or not.  That how
> most projects work.  I'm not subscribed to every kernel subsystem
> list, but my messages usually make it through.  If we are proposing to
> do away with the mailing list, what is the plan for non-patch
> discussions?  Opening issues in gitlab?

I don't think this was the suggestion. For non-patch review discussions 
the list still makes sense. The great thing now is that without patches 
being sent to the list its easier to actually notice these discussions.

> 
> Alex
> 
>>
>> Dylan
>>
>> Quoting Alex Deucher (2019-12-10 07:30:43)
>>> How do we deal with drive by fixes?  E.g., some random user submits a
>>> fix but doesn't want to create a gitlab account just to submit a fix?
>>> Whoever reviews the patch should submit an MR?
>>>
>>> Alex
>>>
>>> On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker <dylan at pnwbakers.com> wrote:
>>>>
>>>> Hi everyone,
>>>>
>>>> I think its time we discussed whether we're going to continue to do patch review
>>>> on the mailing list, or if it it should all go through gitlab. I think we should
>>>> stop using the mailing list, here are some reasons:
>>>>
>>>> 1) Most development is happening on gitlab at this point, patches on the mailing
>>>>     list are often overlooked
>>>> 2) The mailing list bypasses CI which potentially breaks the build
>>>> 3) Probably more reasons I'm forgetting.
>>>>
>>>> Please discuss,
>>>> Dylan
>>>> _______________________________________________
>>>> mesa-dev mailing list
>>>> mesa-dev at lists.freedesktop.org
>>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>