[Mesa-dev] [PATCH 1/2] panfrost: Initial stub for Panfrost driver

[Jason Ekstrand]

On Sun, Feb 3, 2019 at 6:18 PM Alyssa Rosenzweig <alyssa at rosenzweig.io>
wrote:

> > Small comment, you should plan on single build for all supported
> > generations.. I'm not entirely sure if this same header is eventually
> > planned to be #include'd from different C code w/ different defines
> > for gpu gen (afaict you just currently hard-code it at the top of this
> > header)..  But distro's will be unhappy if it comes to different mesa
> > builds for 8xx vs 6xx ;-)
>
> Yeah, that's a moderately high-prio item, only blocking on other things
> being more interesting ;)
>
> > Also, I guess for your sanity at some point you'll want to autogen
> > cmdstream encoding and decoding from a single source.  I get the
> > impression that envytools isn't the right thing for the bitpacked
> > format for mali cmdstream.  Maybe the intel thing is better?  But I
> > didn't get very far w/ a2xx r/e before I realized that keeping hand
> > coded decoding and encoding in sync sucked.
>
> Sure, but.. autogen from.. what? As you note, Mali's "cmdstream" is
> wacky and doesn't line up with the model assumed by most of these tools.
>
> Also, if I have to read/write XML, I might lose my sanity faster ;P
>
> > Anyways, totally fine w/ those details getting worked out in-tree,
> > after merging.
> >
> > Acked-by: Rob Clark <robdclark at gmail.com>
>
> Thank you!
>
> (Is there any particular ack we're waiting for for pushing?)
>

I don't think so.  You've gotten enough buy-in from the community so far
that, if your build system and core (if any) changes aren't going to break
anything, you should just land it and start doing in-tree development!
Right after the 19.0 branch point (which was Wednesday) is a great time to
do it too because any small breakages won't cause any release problems.

--Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190203/d304b4ba/attachment.html>