[Mesa-dev] [PATCH] panfrost: Use u_pipe_screen_get_param_defaults

[Eric Anholt]

Alyssa Rosenzweig <alyssa at rosenzweig.io> writes:

> Switching to the defaults function cleans up pan_screen.h markedly and
> futureproofs for when new PIPE_CAPs are added.
>
> Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
> ---
>  src/gallium/drivers/panfrost/pan_screen.c | 157 +---------------------
>  1 file changed, 6 insertions(+), 151 deletions(-)
>
> diff --git a/src/gallium/drivers/panfrost/pan_screen.c b/src/gallium/drivers/panfrost/pan_screen.c
> index 0e745583940..0fe90db0b0a 100644
> --- a/src/gallium/drivers/panfrost/pan_screen.c
> +++ b/src/gallium/drivers/panfrost/pan_screen.c

> @@ -288,111 +221,33 @@ panfrost_get_param(struct pipe_screen *screen, enum pipe_cap param)
>                  return 1;
>  
>          case PIPE_CAP_VIDEO_MEMORY: {
> -                /* XXX: Do we want to return the full amount fo system memory ? */
>                  uint64_t system_memory;
>  
>                  if (!os_get_total_physical_memory(&system_memory))
>                          return 0;
>  
> -                if (sizeof(void *) == 4)
> -                        /* Cap to 2 GB on 32 bits system. We do this because panfrost does
> -                         * eat application memory, which is quite limited on 32 bits. App
> -                         * shouldn't expect too much available memory. */
> -                        system_memory = MIN2(system_memory, 2048 << 20);
> -

This hunk looks out of place in what is otherwise a refactor.

Other than that,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190205/6660589b/attachment.sig>