[Mesa-dev] [PATCH 2/2] panfrost: Include glue for out-of-tree legacy code

Jason Ekstrand jason at jlekstrand.net
Wed Feb 6 05:27:14 UTC 2019


On February 5, 2019 20:56:25 Alyssa Rosenzweig <alyssa at rosenzweig.io> wrote:

>>> @@ -39,7 +39,7 @@ files_panfrost = files(
>>> 'pan_blending.c',
>>> 'pan_blend_shaders.c',
>>> 'pan_wallpaper.c',
>>> -  'pan_pretty_print.c'
>>> +  'pan_pretty_print.c',
>>> )
>>>
>>> inc_panfrost = [
>>
>> This hunk seems unrelated...
>
> ..Oops, although looking at other drivers' meson.builds, it's reasonable
> to have the comma there anyway for future proof, no?

I like to keep a trailing comma at the end of lists when the language 
allows it. It means that a future addition to the end of the list only has 
+ lines and not a -/+ pair to add a comma.

--Jason




More information about the mesa-dev mailing list